All comments

• 

  Lance Martija• 185

  @lancemartija

  Submitted almost 3 years ago

  Hi, it's my first time building a functioning website using Vanilla JavaScript and Sass. I would like to hear your insights and suggestions on how to improve my skills for my Front-End Development journey.

  If possible, I would like to know what you think are the best practices when coding in JavaScript, and I would also love to get some insights with the naming conventions (i.e. BEM) that I've used in this project I made.

  I know my JavaScript codes in this project are quite a mess, so it would be of great help for me to get your suggestions on how to improve it.

  Thank you for reading and for sending your replies!

  

  Tip Calculator using Sass and Vanilla JavaScript (Updates Realtime)

  2

  2

  0

  

  YksRocks• 100

  @YksRocks

  Posted almost 3 years ago

  This is awesome!

  Great job. Though I have to point out something not that it is very bad but when I want to type number of persons I have to scroll the page this is a very small thing but it will make it easier to use. I know you can easily fix this. Anyhow, well done.

  0

  This comment has received 1 replyShow
• 

  Cornelius Ogunjeminiyi• 115

  @cornelldev

  Submitted almost 3 years ago

  What would have been better?

  

  Semantic HTML5 markup, Flexbox

  1

  1

  1

  

  YksRocks• 100

  @YksRocks

  Posted almost 3 years ago

  Wow, dude, you did a very good job I like it. But there is a very small problem there is the place in the site where the photos have arranged the width of the photos does not match with the width of the other content on the page. I know you can very easily fix this problem.😇

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Ratna Kumar Singh• 250

  @rks1995

  Submitted almost 3 years ago

  Hi i'm a newbie to js and this is my first project related to js, i have learned many important concept related to js and some useful css as well like animation, transform, translate etc.

  Any suggestion on this project as i know there is some bug, related to placing the "box" but i did my best to make it look alot like the design :p

  Any feedback would be appreciated thankyou.

  

  html & scss

  1

  1

  0

  

  YksRocks• 100

  @YksRocks

  Posted almost 3 years ago

  Wow, you did a pretty good job I like it very much. But there is a problem when I click on the down arrow or up arrow I have to click 2 times on it. To be specific when I open one of them and when I click the other one by opening the first one I have to click the arrow two times and this is also happening when I am closing it. I know you can fix this easy so keep it up.😇

  0

  This comment has received 2 repliesShow