Nurbek Makhmudov• 30
@NurbekMakhmudov
Submitted
Rate it!
Any tips are important to me.
Zethess
@Zethess
All comments
- Zethess• 430
@Zethess
Posted
Good morning mate, I was reviewing your code and I leave here a couple of suggestions to improve it, I hope you find them useful.
Remove p-5, you dont need it: https://github.com/NurbekMakhmudov/results-summary-component/blame/66e3be05cb85e2effea59080d509d71fa5caa940/index.html#L18
Add d-flex, justify-content-center align-items-center and vh-100: https://github.com/NurbekMakhmudov/results-summary-component/blame/66e3be05cb85e2effea59080d509d71fa5caa940/index.html#L15
Change this line to the following code: linear-gradient(to top,var(--light-royal-blue), var(--light-slate-blue)); https://github.com/NurbekMakhmudov/results-summary-component/blob/66e3be05cb85e2effea59080d509d71fa5caa940/assets/css/app.css#L25
Besides this, I recommend you to check the colors, play with the opacity to bring your design closer to the one provided. Otherwise good job, keep up the good work.
You have this same message in your github mailbox, I forward it here too
Best regards
Marked as helpful
0 - R.J• 40
@novice-is-me
Submitted
Is my solution correct?
Is there any tips you can give to make the website more responsive?
Zethess• 430@Zethess
Posted
I see it quite well, I would only modify two things for aesthetics.
-Try to add the style border:none in the div with the class "container". You will see how disappears the white border that contains the image bg-pattern-card.
-If the screen is less than 375px wide, the design is disappearing, try adding flex or grid design, I recommend you to check the code of another programmer, for example I have it implemented, if you want to take a look.
Greetings and continue like this, you will see how little by little you are improving your layout skills.
Marked as helpful
0 - ROCKY BARUA• 1,090
@Drougnov
Submitted
Hello everyone, this is my 17th solution.
Please give some feedback or suggestion on this.
Zethess• 430@Zethess
Posted
Good afternoon mate, I was looking at your code and I noticed that the footer logo was not loading. I have reviewed your code and I saw that you are missing a "." in front of the "/" that makes the image does not load well, on line 98 of the html.
-98 <img src= "/images/logo.svg" alt="logo" id="footer-logo">
Best regards
Marked as helpful
1
