Skip to content
OverviewSolutions
8
Comments
2
Aaron Romanick
@aaron-romanick

All comments

  • Aaron Romanick•270
    @aaron-romanick

    You followed the design fairly well with your CSS so that it matches the design specs on both desktop and mobile! Great!

    A few things to keep in mind for next time:

    • I'm wondering why you changed the height of the bars in the spending graph. I know when you mouse over them, they change height to match the design docs, but I'm having difficulty figuring out your purpose. Also, the bars "jump" horizontally when you mouse over them so it makes it difficulty to mouse over.
    • I would maybe add a min-width to your overall container so that at very small sizes the design doesn't break.
    • I'd double check your semantic use of header elements; you have an <h2> before an <h1>, which 99.9% doesn't happen. Use your CSS to style heading tags, not the default browser styles.
  • Aaron Romanick•270
    @aaron-romanick

    Great start!

    One thing I noticed is that if you hit the "Reset" button, the theme toggle switch jumps to the #2 position unexpectedly.