please check on the desktop view if my code is okay on the grid, and also a comment would help
abdoX1
@abdoX1All comments
- @FavskidWhat specific areas of your project would you like help with?@abdoX1
great work
maybe change some font sizing in the heading and add a bit more box-shadow, and increase the size in general
- @YeraoWhat specific areas of your project would you like help with?
i was wondering if i shouldve made only grid rows and in each made a flex box and list the item and values, instead of using grid and make 8div . it didnt sound right to me or there is even a better way to do it ?
@abdoX1your work is great.
I did 4 divs instead of 8. inside each one did 2 spans, one for the name and one for the value. with a span in between each div for the line
Marked as helpful - @vudz2310@abdoX1
hi, good work
but you forget to use the correct fonts and forgot the word "Perfume" and the backGround color, other than, you are good
- @thatswhatshesaid27What specific areas of your project would you like help with?
suggestions based on CSS will always be welcomed, thanks in advance
@abdoX1I think you need more work
- @jeremie1207What are you most proud of, and what would you do differently next time?
Make the page responsive without to use media-query.
What challenges did you encounter, and how did you overcome them?Find what was the color used on design without figma file.
@abdoX1looks good to me
- P@userMauro-codeWhat are you most proud of, and what would you do differently next time?
lo logre sin ver tutoriales y hacerlo con calma
What challenges did you encounter, and how did you overcome them?usar display flex
What specific areas of your project would you like help with?en hacerlo responsivo y hacer el HTML lo mas semántico posible dando clases correctas
@abdoX1I bit of margin on the profile from the bottom and some changes to box shadow and you will be set to go
Marked as helpful - @evolutionusWhat are you most proud of, and what would you do differently next time?
The completion of the challenge. I don't think I would do anything differently.
What challenges did you encounter, and how did you overcome them?I had trouble with aligning the qr image in the div element; using css align-content:center;. I ended up using margins and padding to align the image.
@abdoX1hello, my code brother
you did a good job in your project, but I would prefer making it a bit bigger and centering the container in the y axis would be lovely.
consider using: position: absolute; top: 50 left: 50 transform: translate(-50%, -50%)