Skip to content
  • Unlock Pro
  • Log in with GitHub
Profile
OverviewSolutions
3
Comments
2
abdullah-mn
@abdullah-mn

All comments

  • BISHNU POKHREL•10
    @bisu22
    Submitted almost 3 years ago

    used div element as classes for css styling

    #itcss#accessibility
    2
    abdullah-mn•70
    @abdullah-mn
    Posted almost 3 years ago

    Hi @bisu22,

    • you don't have a CSS folder in GitHub. Therefore you can either create a new folder and place your style.css file in that folder.

    OR

    • you can get rid of css/ path in your link, like this <link rel="stylesheet" href="style.css">.

    and same rule to your img element, <img src="image-qr-code.png" alt="QR code">. always try to add some text to alt=" " attribute.

    I think this feedback will helpful, and best wishes for your upcoming challenges.

    Marked as helpful
  • Olabisi G. Adekoya•70
    @labisigloria
    Submitted almost 3 years ago

    QR Code component challenge

    3
    abdullah-mn•70
    @abdullah-mn
    Posted almost 3 years ago

    Hi ! you did good, but there are some small changes you can do to make it more good.

    • you don't need media query @media in this challenge. Remove the media query.

    • And also use flexbox to center the card, and remove the margin properties from body.

    • And always try to use min-height property, not height.

    I thin this comment will helpful. and Good luck to your upcoming challenges.

    Marked as helpful
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub