Adrian R.

Latest comments

• 

  Vishal Pawar•200

  @vishalpawarR

  Submitted over 1 year ago

  What are you most proud of, and what would you do differently next time?

  I learnt basics of figma designs and it was very helpful how the properties helped me build this project ASAP.

  What challenges did you encounter, and how did you overcome them?

  I was facing issue initially using the Figma but I was able to create a issue in help channel and was able to solve with people help.

  What specific areas of your project would you like help with?

  I need few inputs regarding these:

  • I want help in checking I have added the heading thing in p tag should I use any specific tags for bold point?
  • I have not added any media query as the card size is very small that is 320px and do we need to add some margin for the below screen size of 375px?
  • Please review my class naming convention and html schema
  • How to check the font size in the Figma file? I tried searching it but it was not helpful

  

  Flex QR code component

  2

  30
  

  Adrian R.•50

  @adriarodr

  Posted over 1 year ago

  Hello Vishal Pawar, For the card-heading, I recommend utilizing a heading tag (h1-h6) to ensure accessibility and the tag provides bold styling. I consider eliminating the qr-content div unless it serves a specific purpose. Other than that, everything looks great. Regarding the font size, I struggled at first to find the font size in the Figma file. To find the font size, I clicked on the background (not within any frame) to reveal the local style on the right panel. The fonts and font size will be underneath the text style. The heading is 22px, and the body is 15px.

  1

  Marked as helpful