Akshay Magrani• 975
@akshaymagrani
Submitted
Akshay Magrani
@akshaymagrani
All comments
- Akshay Magrani• 975
@akshaymagrani
Posted
@nayem567, I checked the Github repo, I don't get any such error.
0 - NoorAlhijab• 385
@NoorAlhijab
Submitted
Hello everyone, I would like to hear any advice or suggestions to improve my code and media query as well. Thank you in advance.
Akshay Magrani• 975@akshaymagrani
Posted
@NoorAlhijab, Hello, Nice Coding! It matches quite well. Did you notice the list in your footer section though? It needs to be left-aligned instead of the center.
Indentation and a slight gap between each section is good practice, which I see you have incorporated here in your code (I looked over your GitHub HTML code). Might I suggest you also incorporate comments to highlight each section? As well as in your CSS files where feasible.
As for media query, where you used max-width, I generally go with min-width to add breakpoints. I don't see any reason why there should be only one correct way. Practice and find out which works for you.
There are resources available for free - (https://www.frontendmentor.io/resources). Go over them, you are sure to find something to teach yourself. I know I do.
1 - Jurijus• 300
@juryous
Submitted
Would appreciate your feedback
Akshay Magrani• 975@akshaymagrani
Posted
Hello @jurijus, I think you nailed this one. A little suggestion - try to incorporate comments in your code to explain what a particular block of code does - in HTML and CSS. Have you given thought to using variables in CSS? I have been using them in my recent works and they help. Maybe you can try that in your later projects.
2 - KESHAV GOYAL• 50
@keshavgoyal2807
Submitted
How to get the idea of height and width of boxes? Any source to learn the advanced css libraries?
Akshay Magrani• 975@akshaymagrani
Posted
Hello @keshavgoyal2807, I will answer the latter portion of your question first - You can learn advanced CSS libraries through a variety of resources.
Frontend Mentor has a well-made collection of these resource links on hand that you can try. Follow this link - (https://www.frontendmentor.io/resources) and choose as per your wish.
Regarding your first question, you can choose to take a trial run of Sketch for more pixel-perfect output. Alternatively, there is Figma, which is opensource and free, though how well each measure up to the task will be up to you as I have only superficially gone through them.
Hope this is helpful.
2 - Cory R• 100
@CoryRunn
Submitted
How can I make my
atags accessible? I'm using font awesome icons for the links. UPDATE: I addedaria-trueand atitleto the font awesome that was nested inside theatags. Now it works!Akshay Magrani• 975@akshaymagrani
Posted
Great work, Cory! You managed to resolve the issue yourself. And thank you @GerbenDol, your advice was helpful. It prompted me to work out your suggestion in codepen.io and it worked. That should be helpful to me in the future.
0 - Cory R• 100
@CoryRunn
Submitted
How can I make my
atags accessible? I'm using font awesome icons for the links. UPDATE: I addedaria-trueand atitleto the font awesome that was nested inside theatags. Now it works!Akshay Magrani• 975@akshaymagrani
Posted
Hey Cory,
Regarding making your media links clickable from the circle - You can nest the media within a button element, something like this -
<button name="button" class="button"><"Your media icon"></button>Use CSS to make the button circular - width, height, and border-radius.
Hope this helps.
0
