Skip to content
OverviewSolutions
9
Comments
9

Amar Kosare

@amar215India170 points

I am on Frontend mentor to practice and sharpen my skills. I have a good command of HTML, CSS, and JavaScript. I use Tailwind CSS as well. Currently learning ReactJS. I use the Mobile first approach. "Coding something every day" is my motto.

I’m currently learning...

Currently Learning ReactJS and SASS.

Latest solutions

View more solutions

Latest comments

  • Amar Kosare•170
    @amar215

    The challenge looks as it is required by the Frontend mentor.

    I have one suggestion for you. Please change the README file. first, read the instructions in the README file.

    also, make sure to add the screenshot of the project that YOU made. This will make sure that whoever visits your GitHub profile will find that you as a developer follow all the standard procedures and best practices.

    Happy Coding!

    Marked as helpful
  • Amar Kosare•170
    @amar215

    I think you did not host this challenge on netlify.

    please read the README file from the challenge. there you will find the steps to follow to host the challenge.

  • Amar Kosare•170
    @amar215

    Hello Krishna,

    You forgot to add the images in your challenge.

    do use picture tag of HTML.

    <picture> <source media="(max-width: 768px)" srcset="small-image.jpg"> <source media="(min-width: 769px)" srcset="large-image.jpg"> <img src="fallback-image.jpg" alt="Example image"> </picture>

    this was you can show 2 images whenever size changes. this makes your project mobile friendly.

    Marked as helpful
  • Amar Kosare•170
    @amar215

    You made really nice project. Looks exactly what the frontend mentor challenge looks like.

    You just need to increase the font size of the heading. you can use the font-size property.

    also, You forgot to edit the readme file on GitHub. read the instructions from README there is written that you have to delete the README and make README-TEMPLATE your actual README file. while adding your screenshot.

    this way, whenever anyone sees your GitHub profile. It will look elegant and shows that you follow the best practices. Happy Coding!

  • Amar Kosare•170
    @amar215

    I took a lot of time to finish this project too. ( I chose this as my first project).

    You made exactly what the front-end mentor wants you to make.

    there is only one thing that needs an update. 'the font color' of the card and the background color of the button. this will be really easy to fix. use font-color and background-color properties and you made exact replica of the challenge.

    and please don't quit. You will make a lot of progress in the future. just keep on doing challenges even if it takes weeks to finish one. you will learn a lot. Happy Coding!

  • Amar Kosare•170
    @amar215

    Your Code is very well written. (for my eyes, at least 😂).

    Just learned that we can use <picture> tag in HTML to switch images. in <picture> tag we give 3 elements. 2 are sources to images giving them max-width and min-width for responsiveness. and 3rd element is <img> to view the image.

    I almost forgot that we can use flex to center the 'Price' section and 'Button' section which is that 'cart' SVG and 'add to cart' text.

    Above all, the solution was great!

    Marked as helpful
View more comments