All comments

• 

  Ubaka•130

  @Ngeneubaka

  Submitted over 2 years ago

  

  Product Preview Card Component using HTML5 CSS3

  2

  20
  

  Anna•1,070

  @annaindistress

  Posted over 2 years ago

  I would advise you to add a border-radius to the container element. This will make it easier to find and change this value in one place if, for some reason in the future, it needs to be changed.

  .container {
      border-radius: 0.625rem;
      overflow: hidden; /* this hides image corners */
  }
  

  I also wanted to suggest taking another look at using the article tag for just the container element. According to its specifications, it's meant to represent content that can be taken from this page and placed somewhere else without losing its meaning. So, while the whole card could be an article, it might be better to use div for each individual part

  0

  Marked as helpful