@therealmaduanusi
Submitted
Honestly it took me 5-6hrs to complete this but I finished it anyway😊
Looking to hire developers?
@anoshaahmed
@therealmaduanusi
Submitted
Honestly it took me 5-6hrs to complete this but I finished it anyway😊
@anoshaahmed
Posted
5-6hrs is quick. good job!
@jacksmith77
Submitted
Is there a better, more up to date way to write this code? For the HTML and CSS.
@anoshaahmed
Posted
Aim to use semantic tags when writing html. I would change div class="card"
to main class="card"
. I'll also wrap the image in an h1
. I see that you wrote two separate codes for the two screen sizes. Instead of that, I would recommend that you write the mobile code as your base code, then make a media query for the bigger size. For example, you can give a max-width to something, and then in the media query for the bigger size, you would just increase the max-width. That way you're building a responsive design but also doing less work
you did great though. that's ^ just a way for u to upgrade ur behind-the-scene skills
@ahmed9aks
Submitted
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
you should have at least one <h1>
in your webpage
add alt=""
to your <img>
tags
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@adilido99
Submitted
all feedbacks are welcome !
@anoshaahmed
Posted
hey good job on this challenge! you should have at least one <h1>
in your webpage
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@smmoses
Submitted
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
add alt=""
to your <img>
tags
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@Marvyn21
Submitted
@anoshaahmed
Posted
hey good job on this challenge! wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@abdoachhoubi
Submitted
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<h1>
, and move up by one level each time<html lang="en">
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@RTX3070
Submitted
Feedbacks are welcome! : )
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
<section>
and <article>
usually need a heading; if you don't need a heading, use some other element such as <div>
use classes instead of id's, if you're going to use the same one more than once
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@s0h1s2
Submitted
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<h1>
in your webpagehere is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@lucioew28
Submitted
What can i do better.
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<h1>
in your webpage<section>
and <article>
usually need a heading; if you don't need a heading, use some other element such as <div>
here is a list i made of accessibility issues & best practices
hope this helps :))
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks herealt=""
to your <img>
tagsimg
as the h1
, then the img
must have an alt
attributehere is a list i made of accessibility issues & best practices
hope this helps :))
@AdelaSch
Submitted
Hi all, I'm a beginner and would appreciate your feedback as I feel like I'm overcomplicating things :)
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
add alt=""
to your <img>
tags
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@Elbassel511
Submitted
Feedback is welcome
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
<section>
and <article>
usually need a heading; if you don't need a heading, use some other element such as <div>
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@Elyasthr
Submitted
Hey, I need good advice about:
@anoshaahmed
Posted
hey good job on this challenge! wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@MajidiyM
Submitted
Hello everyone✌🏻, if you check my code and give me suggestions to how improve it, I would be very appreciated, Thanks
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<h1>
in your webpagehere is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@jeeberharter1
Submitted
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<h1>
in your webpagehere is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@unexunderscore
Submitted
I had to retype the error message code because it didn't appear in the right place before. Other than that, it went well. I guess. :D
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<a>
should have an aria-label
. learn more<input>
must have corresponding <label>
here is a list i made of accessibility issues & best practices
hope this helps :))
@PrinceKumar931
Submitted
@anoshaahmed
Posted
hey good job on this challenge! wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@DaviAllevato
Submitted
@anoshaahmed
Posted
hey good job on this challenge! wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@abizmo
Submitted
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<h1>
in your webpagehere is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@DeadParadox
Submitted
Any feedback is appreciated :)
@anoshaahmed
Posted
hey good job on this challenge! wrap everything in your body in <main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here
here is a list i made of accessibility issues & best practices
hope this helps :))
@cwslinda
Submitted
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<section>
and <article>
usually need a heading; if you don't need a heading, use some other element such as <div>
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@asj1928
Submitted
@anoshaahmed
Posted
hey good job on this challenge! you should have at least one <h1>
in your webpage
here is a list i made of accessibility issues & best practices
hope this helps :))
Marked as helpful
@sarveshhiwase
Submitted
If there are any improvements possible with media queries, please let me know.
@anoshaahmed
Posted
hey good job on this challenge! your report above shows a few issues though:
<main>
OR use semantic tags!
if you're using div
right after body
, then give them a role=""
; however, it's a little frowned upon to use role
right after body, so try to stick with semantic tags instead.
you can read more about landmarks here<h1>
in your webpagehere is a list i made of accessibility issues & best practices
hope this helps :))