Hey Guys, This is my 4th Frontend mentor challenge.
Looking forward to any feedback. Thank you.
Looking to hire developers?
@atif-dev
Hey Guys, This is my 4th Frontend mentor challenge.
Looking forward to any feedback. Thank you.
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
Marked as helpful
Feedbacks are welcomed, & it'll enhance my skills :)
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
min-height: 100vh;
in body selector inside CSS.main
selector.margin-top: 1em;
in .attribution
selector..container {
display: flex;
border-radius: 0.5rem;
overflow: hidden;
border: 0.1rem solid #ebdddf;
box-shadow: 0 0.2rem 1rem black;
height: 25rem;
max-width: 520px;
}
.left-side {
background: url(images/image-product-desktop.jpg);
background-size: cover;
background-repeat: no-repeat;
height: 100%;
width: 50%;
}
@media (max-width: 525px)
.container {
display: flex;
flex-direction: column;
height: 39rem;
width: 20rem;
}
@media (max-width: 525px)
.left-side {
background: url(images/image-product-mobile.jpg);
background-position: center;
background-size: cover;
background-repeat: no-repeat;
width: 100%;
}
--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝: Twitter , Instagram , LinkedIn , GitHub
@Martin-00789
Submitted
All feedback is welcome. Thanks for taking the time.
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
em
unit for margin and padding and rem
unit for font-size. Watch here.--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
Marked as helpful
@Wdallas12
Submitted
This was a good quick project to refresh my knowledge of fetching API data. It took some light research to remember how to format the fetch function but outside of that this was a smooth process!
Any feedback is always welcome :)
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take about following points:
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
body {
background-color: var(--dark-blue);
display: grid;
place-content: center;
min-height: 100vh;
}
@media screen and (min-width: 500px)
.container-card {
/* margin: 25%; */
/* max-width: 600px; */
border-radius: 20px;
box-shadow: 1px 7px 40px rgb(21, 30, 36);
}
.container-card {
background-color: var(--dark-grayish-blue);
margin: 0em 1em;
max-width: 600px;
position: relative;
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
padding: 4rem 1rem 7rem 1rem;
border-radius: 10px;
box-shadow: 1px 3px 10px rgb(21, 30, 36);
}
If you are enough comfortable with CSS better learn about responsive units and responsiveness. For responsivness learning, take Conquering Responsive Layouts short course.
When we open GitHub repository link, at right side you will find an About Section. There, also include a description and live preview link of your project.
In README file of your GitHub project's solution remove already present content and write about your own working flow, findings, new learned things, useful resources, etc.
--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
Marked as helpful
@esraa-web
Submitted
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
body {
background: var(--very-dark-blue-main);
font-family: var(--ff-Outfit);
display: grid;
place-content: center;
min-height: 100vh;
}
.container {
color: var(--white);
padding: .8em 1em;
border-radius: 15px;
background: var(--Very-dark-blue-card);
width: 310px;
}
.card-img {
height: 280px;
border-radius: 10px;
background-image: url(./images/image-equilibrium.jpg);
background-position: center;
background-repeat: no-repeat;
background-size: contain;
}
Remove following blocks of code:
@media (max-width: 378px) {
.container {
width: 90%;
}
}
@media (max-width: 420px) {
.container {
width: 85%;
}
}
@media (max-width: 688px) {
.container {
width: 50%;
}
}
@media (max-width: 1024px) {
.container {
width: 35%;
}
}
@media (max-width: 378px) {
.card-img {
height: 280px;
}
}
@media (max-width: 420px) {
.card-img {
width: 100%;
height: 290px;
}
}
--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
Marked as helpful
I still have a hard time using the flex to get each element to be positioned where I want it to be. I would appreciate if you leave a comment if you find that there are better ways to carry out this project.
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take about following points:
body {
background-color: var(--LightGray);
font-family: 'Outfit', sans-serif;
display: flex;
min-height: 95vh;
justify-content: center;
align-items: center;
}
.flex-container {
background-color: var(--MyWhite);
border-radius: 6%;
padding: .8em .1em;
width: 275px;
}
.contenedor_texto {
border-radius: 10px;
margin: 1% 7%;
text-align: center;
}
Remove following code:
@media only screen and (max-width: 600px) {
.flex-container {
width: 80vw;
margin: 20% auto;
padding: 5% 1%;
}
}
(When you will be enough comfortable with CSS then better learn about responsiveness and responsiveness units. You can learn responsiveness units from a free short course Conquering Responsive Layouts).
--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
@nicoleyry
Submitted
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take about following points:
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
<div class="bottom"></div>
block--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
@SadiaImran
Submitted
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
<button id="get-started">Get Started</button>
hover effect not good.<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
@gabrieltrt
Submitted
Hi friends, here's another finished challenge: Social Proof Section.
I hope I can count on your valuable feedback so I can improve more and more!
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. YOU DID WELL🌼😍. Better take care about following points📝.
em
unit for margin and padding and rem
for font-size. Watch Here.
(and if you want to go further to understand responsive units, better explore Conquering Responsive Layouts short course).--Got any questions, REPLY?--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
Marked as helpful
@PiotrPlotast
Submitted
I had troubles with input elements so I'm unsure of my js and styles. Any tips would be appreciated thx.
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
Marked as helpful
@Julie-Gz
Submitted
Hi Frontend Mentor community. I've enjoyed this challenge and learned a lot from it. Would appreciate any feedback and overall tips on how to improve accessibility and form validation. Thank you
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take about following points:
em
for padding and margin and rem
for font-size. Watch here--Got any questions, REPLY--
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub
Marked as helpful
@bhawnapandit26
Submitted
My approach was to first make the body of full screen (using vh) and then add a card to it in the center both horizontally and vertically (using grid). After that I simply added the contents. Is there any better approach to this?
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful
@AidanvG
Submitted
I struggled to get the blue background colour the same as in the screenshots provided. Is there a way to get the RGB/Hex values from a specific part of an image, or is that not possible?
I'm not super familiar with semantics for html, so please could you suggest what elements I could have used instead of divs.
I would also like to know, generally speaking, when it is more appropriate to use % values (or other relative values) instead of px values when working with sizing, margin, padding, etc.
I would also appreciate any other general feedback :)
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge.
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful
@tired-herb
Submitted
Hello, everyone! Could anybody tell me, please, how and where to check wether my page is accessible for screen readers? I also wonder how to make my script shorter if I should. What else colud be better? I would really appreciate your feedback.
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
(If you need any further clarification, you can ask.)😇
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful
@myrhisyoinked
Submitted
hello everyone, hope y'all have a good day. my question is how can I better position elements horizontally and vertically? like how can I make footer at the bottom of the page? Is there any other good practices to positioning elements horizontally and vertically
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
For better look and centered, modify code as:
@media screen and (min-width: 1020px)
article {
grid-template-areas:
"header header"
"price footer";
display: grid;
place-content: center;
width: 70%;
margin: 0 auto;
}
article {
width: 70%;
margin: 0em auto;
margin-top: 7em;
}
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful
Please Give me feedback... What it needs to be improve?
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care about following points.
You must be seeing some accessibility issues, to avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
For better look and centered modify code as:
body {
background: #d4e0ee;
margin: 0;
padding: 0;
display: grid;
place-content: center;
min-height: 100vh;
}
(remove all code inside .container selector)
.qrcomponent {
width: 300px;
background-color: white;
border-radius: 20px;
text-align: center;
padding-top: 10px;
}
.qr {
border-radius: 20px;
width: 91%;
}
(remove all the code from .textParagraph selector)
.title {
font-family: Outfit;
font-size: 20px;
width: 88%;
margin: .4em auto;
}
.sub {
color: rgb(0, 0, 0, 0.5);
text-align: center;
font-family: Outfit;
font-size: 17px;
font-style: normal;
font-weight: 400;
line-height: normal;
width: 89%;
margin: 0 auto;
padding-bottom: 1em;
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
@amita125
Submitted
@atif-dev
Posted
Hi , congrats🎉 on completing the challenge. Better take care about following points.
@media (min-width: 769px) and (max-width: 1440px)
.card {
width: 40%;
}
@media (min-width: 376px) and (max-width: 768px)
.card {
width: 60%;
}
@media (max-width: 375px)
.card {
width: 80%;
}
(after removing above mentioned code, view will look NICE on different screens.)
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful
@RevolutionarySapien
Submitted
my code woks but i certainly know there is space for improvement, feedback is encouraged, and appreciated.
@atif-dev
Posted
Hi, congrats on completing the challenge. Better take care about following points:
body {
display: grid;
place-content: center;
min-height: 97vh;
background: #D6E1F0;
}
article {
background-color: hsl(218, 61%, 87%);
box-shadow: 0px 10px 52px 2px rgb(139, 131, 131);
border-radius: 0.6cm;
}
.div-1 {
margin-top: 0px;
box-shadow: 0px 9px 52px 1px rgb(158, 153, 153);
border-radius: 0.5cm;
background-color: white;
width: 300px;
height: 500px;
}
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
@mercy299
Submitted
@atif-dev
Posted
Hi , congrats🎉 on completing the challenge. Better take care about following points. For little bit more better look you need to modify code as:
body {
margin: auto;
padding: 0;
font-family: 'Karla', sans-serif;
background-color: rgb(204, 223, 241);
display: grid;
place-content: center;
min-height: 100vh;
}
.card {
border-radius: 8px;
display: grid;
grid-template-columns: auto;
}
.white-card {
background-color: rgb(255, 255, 255);
padding: 1em 2em;
border-radius: 19px 19px 0 0;
}
button {
padding: 0.6rem 5rem;
background-color: hsl(71, 73%, 54%);
color: white;
border-radius: 6px;
box-shadow: none;
border-color: hsl(71, 73%, 54%);
margin-top: 1.1em;
}
.cyan-card {
background-color: turquoise;
padding: 1.69em 3em;
color: white;
border-radius: 0 0 19px;
}
(After applying above blocks of code, view will be nice but not responsonsive. You also need to learn responsiveness. You can learn responsiveness from here
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful
@sarahtazyan
Submitted
How can I add the shadow on the button with the exact color and design that is shown in the preview? Thank You
@atif-dev
Posted
Hi, congrats🎉 on complleting the challenge. Better take care about following points:
body {
background-image: url("images/pattern-background-desktop.svg");
background-repeat: no-repeat;
background-size: 100%;
background-color: hsl(225, 100%, 94%);
}
box-shadow: 0px 18px 17px 0px #DFDCF9;
in button
selector instead of box-shadow: 0 1px 2px rgba(0, 0, 255, 0.5);
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful
@Eshita123456
Submitted
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take about following points:
body {
font-family: "Outfit", sans-serif;
background: rgb(229,234,255);
background: linear-gradient(90deg, rgba(229,234,255,1) 0%, rgba(207,218,255,1) 100%);
display: grid;
place-content: center;
min-height: 100vh;
}
and remove all the code inside .wrapper
selector in css.
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
@demisaurusRex
Submitted
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take about following points:
body {
background-color: rgb(205, 226, 247);
display: grid;
place-content: center;
min-height: 97vh;
}
div{
background-color: white;
color: black;
font-family: Helvetica, sans-serif;
width: 300px;
border-radius: 20px;
text-align: center;
padding: 20px 14px;
padding-top: 1em;
}
img {
border-radius: 20px;
width: 97%;
}
h1 {
letter-spacing: -1px;
font-size: 1.6rem;
}
p {
color: grey;
letter-spacing: 0px;
padding: 0em .9em;
font-size: 1.1rem;
}
When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
Include a README file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
@atif-dev
Posted
Hi congrats 🎉 on completing the challenge. You did well, just take care about following points:
rem
for font-size and em
for padding and margin.Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
@jetskeeter1
Submitted
Is there any shorter way that I could have done? Or could I have done a cleaner way in making my card and at the same time centering it at the middle of the page.
@atif-dev
Posted
Hi, congrats🎉 on completing the challenge. Better take care of the following points:
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
.card_container {
width: 250px;
height: auto;
font-size: 0.68em;
background-color: hsl(0, 0%, 100%);
padding: 15px 15px;
text-align: center;
border-radius: 15px;
box-shadow: 0 0 3px rgb(201, 215, 224), 0 0 9px rgb(164, 180, 189);
}
.img-container img {
width: 100%;
border-radius: 10px;
}
.title {
font-weight: 700;
font-size: 20px;
}
and remove following block of code:
.container-box {
padding: 0 20px 0 20px;
}
Hope you will find this Feedback Helpful.
Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn
Marked as helpful