@Rcasas14
Latest solutions
Latest comments
- @barnes
Overall it looks great. When it comes to positioning the button, as the elements are all stacked neatly, you should be able to position just using margins to get the correct positions. I also noticed that you manually uploaded your files to Github. I strongly recommend taking the time to learn to use git in the command line to speed up your process, and be better prepared to work on collaborative projects, especially in a professional setting. Time spent learning git will be time well spent!
Marked as helpful - @phiphphi@barnes
Looks great. In terms of formatting CSS, I'd opt for using classes over IDs generally, though IDs are valid. The general best practice is using a class if your CSS may apply to more than one element, and IDs if the CSS is unique to a single element. In this case, IDs meet that criteria, but if the project expanded to include multiple similar cards, you'd opt for classes. Take a look at the generated report as well to catch those tricky / hard to miss accessibility and HTML validation issues. (Don't forget those image alt texts!)
Marked as helpful - @jdasdeveloper@barnes
Looks excellent. Only feedback I have is to look into centering the main card using Flexbox or CSS Grid to make sure it stays centered vertically and horizontally, even in mobile. Otherwise, excellent work!
Marked as helpful - @KwakuAldo@barnes
Looks good so far! I had the same issues with the mobile design. I had to put a media query around the body to remove the flexbox centering and 100vh when it went to the mobile layout. Good luck!
Marked as helpful - @DevJonatanMorales@barnes
Take a look at some of the HTML issues that are in the report. I also see things like your paragraph and h1 tags getting explicit classes. You can clean up your HTML and CSS if you target those elements within the div in the CSS.
For example:
.section__link p { /* Your section__link paragraph styles here */ } - @Aliza02@barnes
Looks good, as @Old1337 stated, go through the accessibility report on your submission and step through each of the issues. I enjoy using a frontend framework like Svelte, as alongside of their VS Code Plugins, I get warnings and errors related to these kinds of issues before I deploy. Take a look at my solution if you're curious about using something like Svelte.
Marked as helpful
