Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Log in with GitHub
OverviewSolutions4Comments56

All comments

  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi, It looks nice, only thing I noticed the list borders in the professional card is not aligned with others, I am not saying this is bad but in the design file, it is aligned, so you can challenge yourself how to accomplish that design. Good luck

    0
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi, It is always good to make main logo link and takes to index page, so you may improve by adding that. good luck

    0
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @hristoroque , it looks great, you may improve or make it like in design file by increasing padding x direction of main container. good luck

    0
  • Rahul Gupta• 80

    @rahulxyz

    Submitted

    1. For active states of social media icons, I created 2 SVGs with different colors and switched them on hover. (a) Is there any way we can do it with CSS properties like "color" or anything? (b) Or any other better approach to it?

    2. In the articles section, for some size of the screen ( > 1024px i.e. for tablet view), one of the cards would increase in size as compared to others due to content length. For solving it, I have fixed the height for content and change it for different screen sizes. Is there any better approach to it?

    HTML, CSS(+SASS), JS

    3

    Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    looks great, you can make it perfect by adding bg image in hero section. good job.

    0
  • Hiago Riba Guedes• 30

    @Hiaguedes

    Submitted

    It's my first challenge, i learned the basics four months ago but i really thing I did my best. Please feel free to give me some tips and what to study

    ip-address-tracker-master

    2

    Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    hi @Hiaguedes, it looks great, as an improvement you can add correct margins. for example, in Ip address, location, etc they need more space in the bottom. good luck

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @Mostafa-T, it looks great. I think you forget to add " sign to the background . Good luck

    0
  • Sam Buxcey• 35

    @sjbcreative

    Submitted

    Would be great to know peoples thoughts on the basic Javascript I have used to get the popup working, or if anyone has suggestion for how this whole part could be improved... Have I over-complicated this part of the task?

    Also general Markup thoughts and feedback appreciated!

    Thanks, S

    Article Card Preview | SASS, HTML, JQuery

    2

    Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @sjbcreative, so your solution looks great. And using jquery for this task is okay. If you want to learn vanilla js, you can use dom manipulation. It is easier than jquery in this particular case. Good luck

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    HI @shivamvijaywargi , It will be perfect with practice. As a feedback to your work, it already looks well done. as a improvement you can change bg image in mobile by using media queries. Good luck.

    0
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @zuolizhu, this looks amazing. Only thing I noticed, in the form section inputs somehow crapped from the top. especially with "f" it looks clear what I want to say.

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @KimHungChan, everything looks good, It can be improved with some better naming for example buttons container can be changed because they are not probably buttons. Good luck.

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @FelipeDecome, it looks great, however, i noticed the store card get so small before vertical align, you can add some min width or change vertical design earlier. Good luck.

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    @SankThomas hi, It really looks good, in order to make it more appealing, you can add some hover effects to button and social icons. Good luck

    0
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    hi @Dark-Lover, as David said you can make container element flex and alignitems and justify content center will solve alignment problem. Good luck.

    0
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @bboumenir , Generally it is great but there is a problem in the responsiveness of Keep track of your snippets, you can change to flex column early to solve the problem.

    0
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    @sagarkaurav, It looks good, two things I noticed, probably "try it free" is not a button just div or p. And it needs more space for form in a horizontal direction. Good luck.

    1
  • Deepak Kumar• 210

    @deepak300811

    Submitted

    Can anyone suggest how to animate the numbers from 0 to 185 with only css and html? Or a understandable JS approach.

    Using Pure HTML and CSS

    1

    Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @deepak300811, so there are many way what you want to accomplish. You can use keyframes with width property, 0 to 80% or you can access its with js and add 1 per sedond. Good luck.

    0
  • Pedro Lopes• 140

    @PedroLealLopes

    Submitted

    Please provide feedback on how I can better clean up the code. And some feedback on the react side of things as I'm somewhat new to web-development.

    React JS Standard Css Using Flexbox

    1

    Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @PedroLealLopes, as a comment for your react code, you can use destructuring in your components to have cleaner code. for example

    const Card = (props) => {

const Card = ({isMain }) => {

    good luck

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    hi @sharmaeklavya , It looks nice in desktop. I noticed that when we hover button, it shakes because of added border size to button. Good luck with this challange.

    Marked as helpful

    0
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @MuhammadHassaanMahmood5550, it look nice but you can add bg images etc to make it perfect. Good luck

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    Hi @Kerri-AnnBates, sorry I didn't figure out what you are asking. But as a improvement, you can add some padding to top and button in mobile size. Good luck

    0
  • David Omar• 580

    @davidomarf

    Submitted

    Hey! This is one of the most complex projects I've built on React.

    It's the first time I create a theme switcher, and the first time I create skeleton loaders.

    Any feedback is welcome!

    I'm specially interested about the project architecture with the skeletons. I decided to create the component, and the skeleton, both sharing the same stylesheet but in a different file.

    Like this:

    .
├── Countries
│   ├── Countries.module.scss
│   ├── Countries.tsx
│   └── CountriesSkeleton.tsx
├── CountryDetails
│   ├── CountryDetails.module.scss
│   ├── CountryDetails.tsx
│   └── CountryDetailsSkeleton.tsx
│
└── App.tsx

    I think I wrote waaaay to big components. I'll separate them in the next days into something more manageable and 'good-practiced'.

    Country Flags with Skeleton-loaders and Theme Switcher in React

    2

    Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    @davidomarf this looks great, especially I notice you have used typescript. but code looks a little bit messy, in general. And here you use both promise and async-await at the same time. I am not sure about it.

    const fetchCountries = async () =>
  await fetch("https://restcountries.eu/rest/v2/all").then((res) => res.json());

    Good luck.

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    @chri55 Hi, I think you used mixins well. And the design looks perfect. I don't know you are familiar with BEM naming or not. BEM matches well with sass. for example

    // Let's say we have a div name here and inside of it hero we have here__text-box
<div class="hero"><div class="hero__text-box"></div></div>

// we can target them as follows
.hero{
//for hero 
    &__text-box{
    //  for hero__text-box
    }
}

    this is something we want because we target element with only 1 selector (not nesterd, nesting is only in sass not in css) and it is good for later specificity issues. also, we don't write hero :) every time in saas) You can use this method if you like, for more information keywords are BEM and BEM in sass. Good luck.

    1
  • Abdulla Bashiroglu• 520

    @bashiroglu

    Posted

    @nganbarova, It is okay not to be able to do something. As a clue, it is done by using given SVG files in images folder. You just put somewhere and give lover z-index. It going to be easier the more you practice. You can also search these challenges on youtube to see how others did approach the same problem you have faced. Good Luck, keep going. (Uğur olsun)

    0