Skip to content
OverviewSolutions
5
Comments
3
Bisola Onaolapo
@bisoladev

All comments

  • Bisola Onaolapo•160
    @bisoladev

    Great job! I would suggest adding a loading state to help the users be more patient during the latency period of 2 seconds. Other than that, I think it was an awesome work!

    Marked as helpful
  • Bisola Onaolapo•160
    @bisoladev

    Great job! I couldn't see the code to give more observations, the GitHub link seems broken however I would say there could be some improvements in making it responsive:

    1. You could use the 'clamp' CSS property to make the text more responsive.
    2. Max-width, min-width and flex to make the card responsive on all screens.
    3. The button covers some of the text on the card, so I would say making the button absolute and the card relative would work, thereby you could give the button a position of say 50? and it would always stay relative to the card in that particular position

    PS: All the suggestions are hypothetical as I couldn't see the code however I hope it helps!

  • Bisola Onaolapo•160
    @bisoladev

    Great implementation !! I love the fact that you created your own spinner from scratch The only observations I would give are:

    1. I think one divider image would be better and then adding a max width to it so that it doesn't overflow in mobile view...because your implementation though had two different images for mobile and desktop, overflows when it gets to a small-sized mobile
    2. Adding an error state, like an 'oops an error occurred message' when there is an error would be great

    Overall I think it was an awesome job

    Marked as helpful