Skip to content
OverviewSolutions
0
Comments
5
P
boverU
@boverU

All comments

  • P
    Dmytro•200
    @DmytroVoitovych
    What are you most proud of, and what would you do differently next time?

    Using the Anime.js library is something I am proud of since it's a simple and handy library. I were to do it again, I might consider using vue-petite.js, which is a lightweight library that offers strong reactivity.

    What challenges did you encounter, and how did you overcome them?

    Imitating a flexible border on the ticket section that wouldn't overlap the background images was probably the most difficult challenge.

    What specific areas of your project would you like help with?

    I would recommend learning more about the clip-path CSS property. It helps you create unique masks.

    JavaScript, DOM API, Drag and Drop API, Mutation Observer API, Flexbox

    #anime-js
    1
    P
    boverU•60
    @boverU

    If one of the purpose was to become more familiar with DnD DOM API, it is fine. But, you could just leverage label and input tags. Input already natively provides dnd, if you drag and drop files it will work just fine. You can style div or label and bind them listeners you want to use.

    <div>
 <label for='my-file'>
  <input id='my-file'/>
 </label>
</div>

    Animations look really great! I noticed, that you store and export js files, that contains utility functions using assets folder, which is strange. Assets folder is not the place for files like that. I would recommend to use utils folder as a convention between developers.

    Marked as helpful
  • P
    boverU•60
    @boverU

    For, example, this line.

    <div className={styles.planLabel}> <p className={styles.planType}>Annual Plan</p> <p className={styles.planPrice}>$59.99/year</p> </div>

    what if we receive data not statically, but from API - dynamically

  • P
    boverU•60
    @boverU

    Consider to create VStack, HStack components to create markdown with them, not just a lot of the divs. Add some abstractions, based on the props, you can decide what styles could be applied, you can leverage clsx or classnames package. I understand, probably css modules is not so bad and used on the many projects, but it is really time consuming. Consider tailwind css my friend.

  • P
    boverU•60
    @boverU

    It is recommended to leverage Image component from astro:assets for better performance

    Marked as helpful
  • P
    boverU•60
    @boverU

    I notice the layout shifts when you change the astronauts in crews section as the result - twitching dots. I suppose it is because of the length of the texts, they are different size. Probably need to allocate a certain space for the content. Overall looks good!