@ansarstellar
What are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
P
Carlos Santana
@cacesasaAll comments
- P@cacesasa
Hello, good job finishing the challenge. I think you need to try to iron some wrinkles here. Your final result is not close to the original design. Maybe try using some JS to reduce the amount of code that you need to write.
- @raficode2303What are you most proud of, and what would you do differently next time?
the email valid/invalid notification. next time i try to plan the code more clear.
What challenges did you encounter, and how did you overcome them?how to pass data from page to another page. search it online for answer.
What specific areas of your project would you like help with?how to make `` text to align to the top of the
list-style-imageinstead the bottom? what it the AVERAGE estimating time for this kind of project.? Discover easy-to-follow strategies for improving code quality and learning.P@cacesasaCongrats and great job finishing the challenge. Your solution looks good, whith good implementation of semantic HTML as well as reusable and well-structured code. I thing that the success windows are reverse, the desktop view shows when on mobile view and the other way around. Happy coding.
Marked as helpful - @mowzayoP@cacesasa
Hello and congratulation on finishing the challenge. After looking at your code, there are some things that you can improved on, for example, the use of a separate style file instead of writing all your styles in the HTML file, it's easy to read and reuse. The use of media queries to add break points for different screen sizes, if you try your solution on a small screen you'll see that the mobile view is broken. Happy coding.
- P@msjohn41P@cacesasa
Hello and congrats on finishing the challenge. Your page includes semantic HTML and the solution is close to the original design. The code is redeable and reusable. When it comes to resposiness it is a little bit broken because the transition between screen is not seenless, maybe try to use fix width for your different screen sizes, it will make transitions smoother. Happy coding.
- P@inappdesignP@cacesasa
Hello John, First, congrats on finishing the challenge and well done. Your desktop view is almost a carbon copy of the original design, you implemented semantic HTML well and your HTML structure is good. Your code is readable, and reusable. The transition to the mobile view is not perfect, and that is easy to fix. For your media query I recomend setting the min-width to 72rem becuase of the width of the desktop view is around 70rem, instead of max-width for the main tag, just use width: 20.4375rem and don't set a height, it will auto adjust. Hopefully that will help and happy coding.
Marked as helpful - @dirkvankriekenP@cacesasa
Good job finishing the challenge. Your HTML is well structured and your solution shows a good use of semantic HTML. Your mobile solution is really close to the desing but your font-sizes are a little too big. The desktop solution is well design as well but the cards differ from the original a bit but overall good presentation. I will recoment trying to match the design a little closer. Happy coding.
Marked as helpful - @alfonso-ramosP@cacesasa
Hello, Congrats on finishing the challenge. Your desktop solution is good and it match the design, but the design breaks down when trying on small screens, you may need to test your media query on small screens. Another thing is applying semantic HTML to your page . like the use of a main tag and a footer tag as well. Good luck and happy coding.
Marked as helpful - @Ela1650P@cacesasa
Hello, Good work on your project, you show a good understanding of semantic tags. I recomend using media queries for the other 2 screen sizes, and instead of pixels use rem for your units. Happy coding.
- P@YuliaLantzbergP@cacesasa
Hello, Good job on your design. Your code shows the use of semantic HTML design, is accessible and the CSS code is well structure. The only part I think you miss was the use of media querries to create the tablet and mobile break-point for the design. Happy coding.
Marked as helpful - @Nelson-J-MontesinosWhat are you most proud of, and what would you do differently next time?
I am most proud that I was able to complete this project in one sitting.
What challenges did you encounter, and how did you overcome them?I did not encounter any major challenges while completing the project.
What specific areas of your project would you like help with?Making the web page responsive.
P@cacesasaHello, Congrats on finishing the challenge. Great job. Your design include semantic HTLM, and it looks good in the devices I was able to tested it. The only difference to the original design is that there are 2 different design sizes, one for desktop and the other for mobile devices. I recomend using media queries next time to be able to incorporate both of them. Oh, another thing is that when hovering over the card, the box shadow is supposed to doble as well, to achived that I used nested css. Thanks and good coding.
- @luis08201
- @MargumedoP@cacesasa
Good used of CSS flex properties. The program has a good layuot, it's well structured, readable and reusable. The design renders well in a range of screens.
