P
@Ronnarit00000
Latest solutions
Four card feature section
Submitted 7 months agoOverall review of code and if it can be improved or optimized.
Product preview card component
Submitted 7 months agoOverall I would like to know if there is more optimal way in achieving same results and of course is my HTML good.
Social Links Profile
Submitted 8 months agoI would like overall review of code and feedback on what I could improve and what can I change.
Blog preview card
Submitted 8 months agoI'm interested to know if my code is clean, can it be more reduced and compressed. And did I solve correctly challenge where I had to resize fonts without using media queries, or is there some better approach.
Latest comments
- @calakovicalen
Code looks amazing and solution is 99% same as design. Great work!
I have nothing to say but praise and also thanks I did not know you could define your grid layout by using
grid-template-areas, such nice hack! - @Alfonso-1701What are you most proud of, and what would you do differently next time?
Proud how easily I understood how to implement grid. I didn't do the layout 100% correct the first time but I knew what needed to change and how to change it.
What challenges did you encounter, and how did you overcome them?Didn't really run into any challenges. It was a nice smooth pace to completion.
What specific areas of your project would you like help with?Any feedback is welcome.
@calakovicalenYour code looks beautiful, you have completed a lot by writing so little. I will try to take some notes for myself and improve my solution :D
- @8touzineWhat challenges did you encounter, and how did you overcome them?
flexbox playing some tricks with me on mobile version. I ended just using classic margin to center my content.
What specific areas of your project would you like help with?Still didn't get why was my flexbox made some content dissapear when changing the view size to mobile like. They just went overflow at the bottom of the page. I believe this is the reason why you better go Mobile first.
@calakovicalenTry writing your styles in different file for example style.css (For achieving this you need to type inside your HTML
<head>element something like:<link rel="stylesheet" href="style.css" />)Also you can include required fonts, by going to [https://fonts.google.com/] and fining fonts that are giving in style file you get from challenge (inside of it you can even find links to that font) and also you can include that in
<head>element.When approaching some design, try to think of how many boxes (or in developer world how many
<div>elements) you gonna have and what kind of content you gonna put inside that box. For example whole card can be one huge box which holds other two boxes. One box is there for picture and other is for text content. Inside box that holds content you can put at least 4 more boxes.- Holds title
- Holds description of product
- Holds price of product
- Holds button
Avoid using margins inside boxes, but use flexbox and
gapproperty that comes with flexbox.One of reasons why your content disappears on mobile design is because you gave .container a height of 100vh, while this can be good on desktop on mobile content overflows viewport and content disappears, it is always best not to define height at all and let content take up needed space.
Hope my explanation helps, good luck in your future work!
- @ArshiyaASM@calakovicalen
Spacing is off from design. Huge gaps between list items.
Overall good work!
- @Temitimmy@calakovicalen
I'm interested to hear what is reason behind putting all links inside <form>? Then wrapping <input> inside <a> element? I have never seen such approach, if you could share your reasons behind it.
I would suggest less complicated approach, by wrapping <a> elements inside <div> container.
As for CSS I would use some more generic class names, because meaning of yours are currently only understood by you.
If you already put link to all your media, you could put your picture and name as well. ;D
- @madmarshma11owWhat specific areas of your project would you like help with?
Please rate the code, what could be changed for improvement
@calakovicalenHonestly everything to me looks good. I would like to see how would you achieve changing size of font without using media queries?
