P
@tacesept
P
Carlos
@carlosad90All comments
- P@carlosad90
Nice job on the active states, I really like it
- @guardianprimeP@carlosad90
Nice job, some styling need to be improved instead of working with fixed widths, you should try max-width or max-inline-size and adjust them with media queries based on the screen size.
- P@awaritefeWhat are you most proud of, and what would you do differently next time?
I kept my originally method of getting this to work and was an interesting and challenging puzzle for me
What challenges did you encounter, and how did you overcome them?Main challenge was DOM loading and what loads before and after
What specific areas of your project would you like help with?Definitely needs refactoring.
P@carlosad90Good job, I really like how you worked with react neat and in order.
- @FernJBatistaP@carlosad90
Nice job, however you forgot the active states and error messages.
- @MickeyObasWhat are you most proud of, and what would you do differently next time?
I'm use classes and IDs in a neater fashion next time.
What challenges did you encounter, and how did you overcome them?My main challenge was getting the active-state to sync during screen resizes. I guess I got too used to React which makes this somewhat more intuitive through effects and the likes, but it was very fun trying to figure it out.
What specific areas of your project would you like help with?I want to know the best way to make sure a certain visual detail doesn't exist at the screen size not intended for it. I get the feeling that I may have read the instructions too hastily.
The active state (on hover or on click?)
P@carlosad90Nice job, however do not forget to work with semantic HTML or to set up a role if you work with div instead, consider this for accessibility purposes.
- P@librartWhat are you most proud of, and what would you do differently next time?
I learned a lot about grid, flexbox, and media query from this challenge. But, I still need to learn and practice more about flexbox, grid, and media query for responsive web.
What challenges did you encounter, and how did you overcome them?This challenge made me learn and practice more about layouting with flexbox and grid to make good layout for this web, as well as responsive web using media query.
What specific areas of your project would you like help with?I think I would love to get feedback for all of my code from HTML structure to CSS styles, especially the flexbox & grid layout and the responsive design.
P@carlosad90I really like your code, I recommend working with clamp() for the font size so you do not need to use media queries for that, also give SASS a try, you can use mixin for reusable components like the buttons. Good job.
- @jdtb4P@carlosad90
Good job, I really like your code is in order and with comments, also working with semantic html, nice.
- @eslamnasP@carlosad90
Nice job, just a detail, for a wider monitor your section streches too much because you are working with 80% of the width in your div, which is a direct child from the body so it will occupy 80% of whatever screen size you work with, instead you should limit your section with a max-width, in this case max-width:1100px for 1440px and larger screen sizes.
- @Mahmud1AvailableP@carlosad90
Nice job, however you should consider all details in the design such as borders, opacity and sizing. Remember these are critical and does make a difference.
- @FatelessDevilP@carlosad90
Good job, you included semantic html.
- @gustavommcvP@carlosad90
Nice job, you should not forget to style the pseudo classes for the links, this is, active,hover,link and visited.
- @MusabbCoskunP@carlosad90
Good job, I recommend working with relative units like em o rem instead of px. Also you can give a try to the clamp function to set a minimun and maximum font size which changes based on the viewport width.
Marked as helpful - @HadryanLopoWhat are you most proud of, and what would you do differently next time?
I was able to use a simple implementation of HTML and CSS. I kept the project very simple, but next time, I would use Tailwind CSS.
What challenges did you encounter, and how did you overcome them?At first, I had a bit of trouble learning how to use Figma to achieve a pixel-perfect design since I had never used it before, but it wasn’t too difficult to overcome.
What specific areas of your project would you like help with?I need feedback on my code, file organization, structure, and use of tools to complete the challenge.
P@carlosad90Nice job, I really like how you implement meaningful semantic HTML.
