Skip to content
OverviewSolutions
4
Comments
5
Ceesay Fofana
@cfofana

All comments

  • Ceesay Fofana•70
    @cfofana

    Very well done. I like your solution. It gave me some ideas on how I can improve mine.For instance, using a header tag for the img and info about the user. Also, using nav and list items for the links. Your layout also looks good on the many screen sizes I tested it on. Your code is clean, easy to read and easy to understand.

  • Ceesay Fofana•70
    @cfofana

    Good job. I do recommend using clamp() to make the font size responsive though. I didn't know about it till someone told me about it and it worked very well for this project.

    Marked as helpful
  • Amsup•50
    @Amsup
    What are you most proud of, and what would you do differently next time?

    I got some sizes perfectly

    What challenges did you encounter, and how did you overcome them?

    first I couldn't get the exact height and width of the container with its padding, but eventually I had help from some videos explaining the issue and I read some documents from MDN

    What specific areas of your project would you like help with?

    the container height and margins, please help newbie here

    Css flex

    #vanilla-extract
    1
    Ceesay Fofana•70
    @cfofana

    What is your question on the container height? Are you trying to set a height for it? If that is the case, it's not recommended to set a fixed height. It can lead to overflow issues, i.e. the content of the box will flow out of it.

  • Ceesay Fofana•70
    @cfofana

    Great job! One thing I noticed was that you used fixed heights. It is generally discouraged to use fixed heights as it can lead to overflow issues and make things not responsive. Otherwise, great job.

    Marked as helpful
  • Ceesay Fofana•70
    @cfofana

    The attributions are overlapping the qr code.