Consistent naming of pretty much anything.
Brian
@coding-brianAll comments
- @RohloffmeisterWhat challenges did you encounter, and how did you overcome them?P@coding-brian
It's great. However, I think that after answering question, geting into next question automactically is smoother.
- P@ysm0706gleeP@coding-brian
Hi,it's good. However,there's some things that make it better.
- layout should more match to design
- the strength icon didn't work
- P@marcus-hillWhat are you most proud of, and what would you do differently next time?
Proud of my use of HTML & JS
P@coding-brianAfter I input an custom number, I change to select a tip and it didn't calculate the amount.
- @mostafa183P@coding-brian
Hi,how's going. I think it's almost complete. Keeping going!
- @ManojSinghDashauniP@coding-brian
I push the subscription button ,and then redirct me to a '405 Not Allowed' page
- @JavohirXolmamatovWhat are you most proud of, and what would you do differently next time?
great
What challenges did you encounter, and how did you overcome them?great
What specific areas of your project would you like help with?great
P@coding-brianIn modlie layout, the share links layout doesn't match with the design.
- @MarcosAvgWhat are you most proud of, and what would you do differently next time?
I felt good this time to use global values, since the design has many sections with similar styles I think it was beneficial not to repeat code.
What challenges did you encounter, and how did you overcome them?I think there must be a better solution to overflow the image of its parent container in its mobile version, I used a media querie with different styles, but I feel it's a bit forced.
What specific areas of your project would you like help with?On this occasion I would like information on how to handle the images, inside your container I have good notions of how it works, but it was complicated to overflow the image in different resolutions.
P@coding-brianThe hr top and bottom margin isn't the same with desgin, neither is li marker's color.
- @abdelilah-wdP@coding-brian
Your spacing between img and h2 isn't the same with design.According to design,it's 24px.And,I found that spacing you set is 1.2rem.The default font-size of the html is 16px. So, the result is 19.2px (16px*1.2) .
- @MdZaferEqbalWhat are you most proud of, and what would you do differently next time?
I build the blog preview card as mentioned in the challenge, but I am lacking on the responsiveness of the website. I have to work on it.
P@coding-brianThe blog-preview-card-container size is determined by it's content so it's not necessary to set fixed height and width.
Marked as helpful - @gtpower3P@coding-brian
Isn't your modal positioned in the center ? Maybe the body should have margin:0 ? Others, i wonder why body is min-height: 95vh, but not 100vh.