@Mageshwari-Balaguru
Coke Stuyck
@cokecancookAll comments
- @cokecancook
Nice approach! Keep an eye on: · Spacing, alignment and paddings · Overlay should only cover the image
- @vladzen13What are you most proud of, and what would you do differently next time?
clean html css grid usage was quite cool, all spacing is based on gaps, no margins in cards at all. grid-row and grid-column specific values with span is quite cool also quite readable media query
@cokecancookSo close! Looking great!
- @UmarMubeeenWhat are you most proud of, and what would you do differently next time?
this challenge helped me to learn a about grids.
What challenges did you encounter, and how did you overcome them?this task is one of the most challenging for me, had to spend a lot of time to make the layout however still there are issues in solution. making the layout perfect for different screen sizes is the most challenging task.
What specific areas of your project would you like help with?The following are list of issues i could not solve: 1- the specific layout was most difficult to create. 2- my solution works perfectly for lg screens however on medium screens the cards overlaps and on small screen there is a issue of padding. 3- Still need much improvement , if anybody knows , how to make it perfectly please let me know.
@cokecancookKeep it simple! And watch out for the overlaying cards when sizing down the window ;)
- @DhinaGaran96@cokecancook
The approach is good! Here are some issues to check:
- Structure: · main should have a fixed width · main should be centered in mobile · body should have a background-color · review paddings and spacing overall
- Image: · image in mobile should change src
- Fonts: · Should load and apply custom fonts (one of them is https://fonts.google.com/specimen/Montserrat)
Keep it up!
- @carlosmarte23What are you most proud of, and what would you do differently next time?
I successfully styled the table to match the design, although it was quite time-consuming as it was my first practical attempt. I've learned through tutorials, but applying the knowledge firsthand was a new experience. I hope I've done well and I'm open to feedback.
What challenges did you encounter, and how did you overcome them?I had quite a challenge with the table design, particularly adding the bottom border to the rows and centering the text on the page while leaving space on both sides to align with the design. After searching online for the necessary properties, I managed to accomplish it.
What specific areas of your project would you like help with?I'm looking for feedback on the mobile-first styling approach, as well as suggestions to enhance the table's design.
@cokecancookGreat job! I'm a newbie, so don't have much feedback to give. Keep it up!
- @FranekHincmann@cokecancook
Great approach! Should look into the spacing between headers. Grouping similar items does help :)
Marked as helpful - @saeedakrami@cokecancook
Does the solution include semantic HTML? Yes Does the layout look good on a range of screen sizes? Forgot to include media query. Is the code well-structured, readable, and reusable? Yes Does the solution differ considerably from the design? Nope, looks great. Only missing the border.
- @Chalongrath-Kodsriwong@cokecancook
Does the solution include semantic HTML? Yes
Is the code well-structured, readable, and reusable? The css could be in a separate file.
Does the solution differ considerably from the design? Great approach! Things to keep an eye on: External radius, should be different to match the internal radius. Spacing between child elements in the card should be consistent. Shadow should be smoother. Also, consider changing the style of the links :)
Marked as helpful
