P
@Negligence
Latest solutions
Mortgage Calculator made with React & CSS-Modules
#accessibility#react#typescriptSubmitted 8 months agoProduct list with cart made with React
#react#sass/scssSubmitted 8 months agoAt first, I found it hard to understand when to create a component, and as with all things, the internet doesn't seem to agree on the 'correct' way to create them. Some components could be broken down into smaller parts, but overall, I think they’re fine for a smaller project like this, where we don’t have many reused components. I need to find a balance that works for me. I’d welcome any feedback on my current component usage and the project overall. Thanks in advance!
Latest comments
- @cucumerisGIT
Looks good and responsive.
- P@dedo-devWhat are you most proud of, and what would you do differently next time?
There is one thing that makes me proud, is how this solution looks better than the first one on the code side 🥲
What challenges did you encounter, and how did you overcome them?I encountered one challenge on this project, naming variables for the primary colors. Naming things is the harder part of web development 😂
What specific areas of your project would you like help with?I haven't any particular areas where I need help for this challenge but any suggestions are very welcome.
Thanks ✌️
@cucumerisGITYour page looks good and i really like how it matches the original design nearly perfectly. You said that you find it hard to find names for variables but you can reduce the headache if you only declare variables that are used more than once and assign the other values directly to the properties of the elements. Also your page has a little bug in the
hero__headingon smaller screens where the heading is not placed on two seperate lines. Your usage of BEM could also benefit if you nest elements and modifiers inside their respective blocks. That would improve readability and maintainability since all related selectors are together at one location but it is just a "can" and not a "must". You should also always include an "alt" in your img/svg elements, otherwise its not accessible. Overall you did a great job with only minor issues. Keep up the work :)Marked as helpful - @ObadaSawalmeh
- @shiv-pratap04@cucumerisGIT
nice
- @HartmannsgruberBen@cucumerisGIT
looks good!
- @07almasashimbekov@cucumerisGIT
nice
