@a2uuz
Submitted
feedback would be appreciated!!
Looking to hire developers?
@dannxvc
@a2uuz
Submitted
feedback would be appreciated!!
@dannxvc
Posted
Hi! It looks so good. I think you should use the form
markup instead of div
, so your card would be actually accessible. Also you could change your buttons
for radio buttons, and your submit button should have a submit
type attribute.
Finally, this article might help you styling your radio buttons without losing accessibility. Hope this helps :)
Marked as helpful
@carlosegs1506
Submitted
Me costo un poco pero quedo bien agradezco algΓΊn comentario.
@dannxvc
Posted
Hi! So far so good, you should change the h1
tags for p
tags, because it's best practice to have only one h1
tag per page, you can read more about this in this article . That's why you got 6 html issues. Also you could change your p
tags you used for every name to h2
tags. Hope it helps :)
Marked as helpful
@ApplePieGiraffe
Submitted
Hey, everybody! π
This was a fun challenge in which I learned how to use and style the <details>
and <summary>
HTML elements.
I also added a bobbing animation to the floating cube (with a small touch from the drop-shadow
CSS function) and animated the linear-gradient
background with this helpful tool.
I'm quite happy with the result! π
Any feedback on both the design and code is welcome and appreciated! π
Happy coding! π
EDIT: For some reason, the details marker on each of the FAQs is showing up in the screenshot (even though I set their display
to none
) but they're gone on the actual page, as far as I can tell.
@dannxvc
Posted
Oh this so amazing!!! I truly love this, you are so creative. I think I would change the card's height
as min-height
, so then if all of your questions are opened, they could be seen and to make your cube-img look as good as it does now, you could position it by using top:40%
and transform: translateY(50%)
, that would be sick. Amazing job as always!
Marked as helpful
@MinaEssa-Soliman
Submitted
@dannxvc
Posted
Hi so far so good!! I recommend you to follow the readme file instructions, for you to have a readme about your actual proyect. Also, I'd say you should use the right font weights, so it'll look more like the original design, you could read more about it here.
Marked as helpful