Bruno• 110
@BrunoSousa750
Submitted
The interactive component challenge completed... i think. If there's anything that can be improved, please tell me.
Dana Kalčíková
@danyczech
All comments
- Dana Kalčíková• 90
@danyczech
Posted
I like your solution with radio buttons and the second button to get back to the first card!
Just in your HTML part, the submit button after the radio buttons is missing, and instead of it is an <a href="#" id="submit" class="main--btn">submit</a> tag. It makes no sense there... It would be better to use this:
<div> <button type="submit">Submit</button> </div>Also using <form> and <fieldset> elements would be better, more there
And a minor thing - the color of the texts in <p> tags and inside marking buttons are not white, but grey.
Marked as helpful
1 - Gabriela• 180
@PaulaR-05
Submitted
Hi! :) any feedback and suggestions are welcome! Thank you
Dana Kalčíková• 90@danyczech
Posted
Hi Gabriela!
Nice job!
At first sight, the picture of a cart is missing inside the submit button - it is the icon-card.svg file inside the images folder. Also, the text inside the <p>tag has the other font and more space between lines (it is line-height property, I have line-height: 1.5 ) and there is less space between headline text lines.
Have a nice day!
Marked as helpful
1
