@jitkama
Submitted
- Vercel gives me 404 mistake, just cannot figure out why?
- If checking the git repository files, my main question were:
Looking to hire developers?
@daudi13
@jitkama
Submitted
@daudi13
Posted
retry launching again by renaming your file and selecting the location of your HTML file(root file) that should work. I had a similar problem when I was starting to use Vercel
feedbacks are welcome, hope u enjoy it
@daudi13
Posted
I like the use of sass in your code, makes it very DRY and precise, I personally didn't find any errors just wanted to say It been a while since I came a cross this type of work. keep up the good work.I have really learnt a lot from your code. codificación feliz
@RocTanweer
Submitted
If you could take some time to review this site and its code, I would love to hear your feedback which will help me GROW! Thank You!
@daudi13
Posted
Hello, I took a look at your code and I must say your site is very responsive for both mobile and desktop display, I found your code to be very DRY and simple.I liked your use of SAAS and BEM naming conventions in the project. maybe aside from the actual design measurements everything else was ok. kudos and keep up the good work. Happy coding :-)
you can upvote a comment if you find it helpful
@Karimsamir112
Submitted
please feel free to give feedbacks
@daudi13
Posted
Hello Karim, thank you for your submission I really think you did a good job on the project . I can see your project is very responsive for both Mobile and desktop display. I just have a few comments on your code.
I noticed you didn't use a div eg .container
to wrap your code after the body
.
You didn't use header
nav
or footer
to group your markup. remember you can create a website using HTML alone but you can't create a website without it. So your markup needs to be understood by the search engines.
You did use button
instead of button:submit
for your buttons.
You didn't add any border-radius
for your buttons.
You didn't use the suggested font-size
, font-family
and font-weights
that came with the README.md file.
Try learning BEM naming convention for naming divs in your HTML.
In general I think you really tried your best. keep being consistent and you'll see the results. Keep up the good work. Happy coding. you can upvote a comment if you find it helpful
@RajMhatre20
Submitted
How is the Responsiveness of the site I mean is there anything I can improve?
@daudi13
Posted
Hi, Raj. I've taken a look at your code and I found your project very responsive in both mobile and desktop. I just have a few suggestions.
1.Make use of BEM naming convention. it is very easy to learn and use. Because it will make working on your CSS very easy and you're going to need it when you work with JS.
2.Avoid using button
for clickable buttons but instead use button:submit
.
Thank you for your submission and keep up the good work. Happy coding.
@KristynRiho
Submitted
Hi, I started learning HTML and CSS 3 weeks ago and I know that my solution is not perfect :-( I hope my next solutions will be better :-). If someone have any advice for improvement of my solution, I will appreciate it. Thank you.
@daudi13
Posted
Hi, I've taken a look at your code and I Just have a few comments and suggestions.
For suggestions i suggest the following:
div
immediately after the body
you can give it any class name you want but .wrapper
or .container
are used universally.margin
, box-sizing
and padding
it is safe to include ::before
and ::after
.@Enol-Igareta
Submitted
Good morning. I did this project using grid and flexbox. Any advice about my code will be very useful to continue improving, I would be very grateful if you could guide me or tell me any error you see in my code. Thank you very much for your time
@daudi13
Posted
Hello, I've gone through your code and I've found it very well organised, responsive, clean and DRY. I've also learnt a lot from it. I did not really find any particular errors in your code. Keep it up. Happy coding.
@mansi05041
Submitted
i tried to make it responsive ..suggestions are welcomed
@daudi13
Posted
Yes try using grid it will make your work much easier and the site will be responsive. Anyway nice job. keep up the good work. Happy coding :-)
@MayankMudgal
Submitted
This is my solution using CSS Flex layout. Please provide your valuable opinion and insight on the solution.
@daudi13
Posted
Hi, I checked your project and I have to mention it was well executed and very responsive . I really really learnt a lot from it. however I just have two issues with your code, first I noticed you didn't use the button tag for your "register" button you instead used a link tag, please check that. Secondly your stylesheet was a bit squeezed and jumbled up I had trouble following it up with your mark up. I suggest styling your elements in order of your html. Anyway thank you for your solution and keep up the good work. Happy coding!!
@KristianDunne
Submitted
I didn't download the Figma files for this one again so the dimensions of the elements are not perfect, but I am just working on improving my use of Flexbox.
@daudi13
Posted
Hi Kristian, your code is clean and precise. the responsiveness is also good I just have two issues I noticed with your code. First I noticed you didn't use any heading and paragraph tags and secondly there is an hidden overflow on the content-box making the content incomplete on devices with smaller screens. Anyways keep up the good work. happy coding!!