@thebigdavec
Submitted
All feedback is welcome. Please note, certain options with detail/summary don't work in the thumbnail. Please check out the live solution.
Looking to hire developers?
@david-r-frederick
@thebigdavec
Submitted
All feedback is welcome. Please note, certain options with detail/summary don't work in the thumbnail. Please check out the live solution.
@david-r-frederick
Posted
Sorry, I should clarify. That graphic isn't centered when the screen is wider. When it's phone width, it's fine. You can find a way to make it always centered though.
@thebigdavec
Submitted
All feedback is welcome. Please note, certain options with detail/summary don't work in the thumbnail. Please check out the live solution.
@david-r-frederick
Posted
Hey Dave! Looks great! A couple things: 1) I would add a transition effect for when the questions open and close. It's not necessary, but it would make a much smoother user experience. 2) The mobile version of the graphic with the woman and the computer is not centered. You have the FAQ header centered, so I'm sure you have the skills to figure it out ;)
@appsplash99
Submitted
This is my first submission via github.
And sorry for the looong url vercel is a long one :p Thank You :)
@david-r-frederick
Posted
You should create separate files for either a) areas of the code by category (for instance: layout, typography, variables, etc.) or b) different components (for instance: the rating cards, the quote cards, etc.). After you have your separate files, you just import them separately into your html file. It sounds counterintuitive and like it's more work, but in the end it isn't because you save yourself time but not having to search for what you're looking for. Other than that, it looks responsive and pretty well done. It's bigger than the initial design, but that's not a bad thing to me. One thing I would change is your media query for the rating boxes. Looking at 5 stars on two different columns is weird. You could either micromanage it by making your content smaller as the width of the window shrinks or (to me, more ideally) you could set an earlier break point for when you change to mobile view.
@NoorAlhijab
Submitted
I'd appreciate any feedback.
@david-r-frederick
Posted
NoorAlhijab, Looks great overall! A few things I'd fix.