Skip to content
OverviewSolutions
6
Comments
3
P

David Inoa

@davidinoaUnited States150 points

Software Engineer

Latest solutions

Latest comments

  • P
    David Inoa•150
    @davidinoa

    Great work overall 👏

    Regarding your markup: using <a> tags with the href attribute set to an empty string (href="") is generally not recommended for several reasons:

    1. Usability and Accessibility: An empty href attribute can lead to confusion for users and can be problematic for accessibility. Users, especially those using assistive technologies, expect links to navigate them to a different page or section of the current page. An empty href can cause the link to do nothing or just reload the current page, which might not be the intended outcome and can be confusing.
    2. SEO Implications: From an SEO perspective, links with empty href attributes are essentially useless. Search engines like Google use links to discover new content and to understand the structure and hierarchy of a website. An empty href provides no value in this context and can be considered a poor practice.
    3. Better Alternatives Available: If the goal is to create a clickable element that triggers a JavaScript action, it's better to use a button (<button>) or to set the href attribute to a hash (#) or JavaScript void function (javascript:void(0);).
  • P
    David Inoa•150
    @davidinoa

    Excellent work! My favorite thing is the scroll animation, very smooth. One minor detail: on mobile, I would try to fix the alignment of the logo and the hamburger menu. Other than that, it looks great! ✨

  • P
    David Inoa•150
    @davidinoa

    This is a very lovely implementation without the need for any frameworks!

    Regarding accessibility, I would suggest adding a visible outline around interactive elements during the focus/focus-visible state to improve keyboard navigation.