Skip to content
OverviewSolutions
8
Comments
5
Dawid Keyser
@dawkey95

All comments

  • Dawid Keyser•170
    @dawkey95

    Hey, nice work on completing the project. 👍🏼 I like how you added the footer and tied it in with the color scheme, so nice touch there.

    One thing I would suggest is just try adding some padding to your card on top and sides. Maybe try 48px of padding just to help create a little space and make the card feel a little bit more balanced.

    Other than that nice job 💯

    Marked as helpful
  • Dawid Keyser•170
    @dawkey95

    Nice work on the solution. I quite like the little change with the title and the advice # with the green border. 👍🏼Cool idea to just make it that little bit more personal. 😃

  • Dawid Keyser•170
    @dawkey95

    Hey nice job with the solution for this project. 😃 I just finished it as well and thought it was quite a fun little project to learn about APIs without being overly complicated. How did you find it?

    I noticed your image links are broken. Not 💯 about how to fix it without trying but one thing you could try is just look at your image path again. perhaps trying src="./images/pattern-divider-desktop.svg" but its hard to see as I haven't tried it in my own IDE.

    Also I would suggest just adding some padding to your card body. I believe yours is called container. Try maybe 48px top and sides.

    Otherwise nice work. 👍🏼📱

  • Dawid Keyser•170
    @dawkey95

    Nice solution man. The tailwind looks like it is worth giving a go in my own projects.

  • Dawid Keyser•170
    @dawkey95

    Hey,

    Loved seeing your solution using react and SCSS.

    How did you go about passing the accessibility reports and html validation? I always end up with landmark errors etc. I use Material UI as my CSS framework but can't figure out how to pass the accessiblity/html validation reports so thought I would check with you and how you approached it.

    Kind regards