@dimolf345
Demetrio Julian
@dejuliansrAll comments
- @dejuliansr
You have done well, the results of your work are perfect
- @DhairyaSehgal07@dejuliansr
You have done your work well, a little suggestion from me to improve the function of the plus and minus buttons, and also the layout for replying to comments can still be improved again so that it is neat
- @ionStici@dejuliansr
good work
- P@AdamullaOsas@dejuliansr
good job, a little suggestion from me, maybe the border countries element on the country details page can be made into an active button to go to another country
- @echocode1@dejuliansr
the work you have done is good, but a little suggestion from me is that you can remove the arrow or spiner in the input
Marked as helpful - P@aouintihouari@dejuliansr
the work you have done is very good. keep practicing so that your skills improve
- @ManikMaityWhat are you most proud of, and what would you do differently next time?
- Semantic HTML5 markup
- CSS custom properties
- Flexbox
- CSS Grid
- Used variables in css
This project helped me to revise my html and css skill.
@dejuliansryour work is very good
- @Maobugichi@dejuliansr
the work you have done is good, but a little advice from me is to tidy up several components so that the layout looks neat and in accordance with the design
- @kadiryildiri@dejuliansr
You have completed this challenge very well. keep practicing your skills so that they continue to improve
- @Maobugichi@dejuliansr
the work you do is very good. keep practicing your skills so they continue to improve
Marked as helpful - @ArcloanWhat are you most proud of, and what would you do differently next time?
Nothing in particular.
What challenges did you encounter, and how did you overcome them?Nothing in particular.
What specific areas of your project would you like help with?I don't know if the markup is semantically correct. If it is I don't know if there is a better way to style the header. I had to give the header a position of absolute to make it work because I thought that nesting it inside the hero section would have broke the semantic meaning. I don't know either if my measure for the images and cards are off. I looked only at the png not at the design files. I should have split my .scss files in a more modular way but since this project is relatively small I didn't gave it much thought. Anyway any suggestions are really welcomed :) Thank you.
@dejuliansrcongratulations on completing this challenge well. A little suggestion from me is to add an overlay to all background images so that the writing can be seen clearly
- P@AlfredKonnehWhat are you most proud of, and what would you do differently next time?
- I was able to build the project.
- Review the project several time before getting stated.
Please review my code and give me feedback. because to implement the hover effect with the overlay wasn't easy.
@dejuliansrCongratulations on completing this challenge well, continue to practice your skills continuously so that they continue to develop
- @Maobugichi@dejuliansr
the work you do is good, we have the same problem with the product thumbnail
Marked as helpful - P@JJorgeMS13What are you most proud of, and what would you do differently next time?
Planearía un poco mas como voy a crear la pagina para poder hacer mejor codigo y lo haría en algun Framework de javaScript como Vue.js ó React.
What challenges did you encounter, and how did you overcome them?El super poner la navegacion en mobile, lo supere con el position: absolut;
What specific areas of your project would you like help with?Me encantría que me ayuden a mejorar la semantica HTML y en la limpieza del codigo.
@dejuliansrthe work you do is very good. keep practicing and developing your skills
- P@JJorgeMS13What are you most proud of, and what would you do differently next time?
Me encanto poder uduar Vuelidate para validar mi formulario.
What challenges did you encounter, and how did you overcome them?Poder validar un checkbox, lo supere haciendo una validación personalizada en vuelidate para que cuando fuera true solo lo dejara pasar.
What specific areas of your project would you like help with?Me encantaría poder hacer componentes mas reutilizables.
@dejuliansrgood job, keep practicing your skills so they can improve
- @Kingoruovie@dejuliansr
good job friend, keep practicing so that your skills continue to improve
- @gk6294@dejuliansr
good job, keep training your skills so they continue to improve
- @Pan1402@dejuliansr
the work you do is good. a little suggestion on the body, you can use
display: flex; justify-content: center; align-items: center;
so that the display is in the middle of the viewport and pay attention to the reset button which should be deactivated when the calculator is still empty. keep practicing so that your skills improve, good luck
Marked as helpful
