@MyselfRoshan
Submitted
@denielden
@MyselfRoshan
Submitted
@denielden
Posted
Hello Roshan, You have done a good work! 😁
Some little tips to improve your code:
alt
attribute of the imagesbroder-radius
to .search-bar
classbody
to change the all theme color of apptransition
on the body to smooth the change theme colorul
element for the details text of country instead of multiple p
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
@meissadev
Submitted
All feedback is welcome.
@denielden
Posted
Hello, You have done a good work! 😁
Some little tips to improve your code:
main
tag and wrap the card for improve the Accessibilityarticle
tag instead of a simple div
to the container card for improve the Accessibilitydiv
container of imagediv
with absolute
positioning is now deprecated, it uses modern css like flexbox or grid
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent containerpx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@EduardIonescu
Submitted
Really nothing to add
@denielden
Posted
Hello Eduard, You have done a good work! 😁
Some little tips to improve your code:
article
tag instead of a simple div
to the container card for improve the Accessibilityclass
to style the element and not id
because the ids must be unique in all the pagepx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@Sunil20011
Submitted
@denielden
Posted
Hello Sunil, You have done a good work! 😁
Some little tips to improve your code:
main
tag and wrap the card for improve the Accessibilityarticle
tag instead of a simple div
to the container card for improve the Accessibilityimg
element must have an alt
attribute, it's very important!alt
attribute of the imagesmargin and width
properties from body
margin
from card and container
classesmin-height: 100vh
to body because Flexbox aligns child items to the size of the parent containerpx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
@DanielLucaci
Submitted
This is my solution for the "Advice generator app" challenge. I spend some time to add a loading spinner when fetching a new advice, but I'm very proud of the final result. Any feedback is highly appreciated.
@denielden
Posted
Hello Lucaci, You have done a good work! 😁
Some little tips to improve your code:
main
tag to wrap the card and improve the Accessibility but not as a container of that elementarticle or blockquote
tag instead of main
tag to the container card for improve the Accessibilitypicture
tag to change image by resolution -> read heremin-height: 100vh
to body instead of height
, otherwise the content is cut off when the browser height is less than the contentpx or %
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@Narnayak95
Submitted
@denielden
Posted
Hi, You have done a good work! 😁
Some little tips to improve your code:
main
tag and wrap the card for improve the Accessibilityarticle
tag instead of a simple div
to the container card for improve the Accessibilityalt
attribute of the imagesmin-height: 100vh
to body instead of height
, otherwise the content is cut off when the browser height is less than the contentpx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@VladoNo1
Submitted
@denielden
Posted
Hello Vlado, You have done a good work! 😁
Some little tips to improve your code:
alt
attribute of the imagesmin-height: 100vh
to body instead of height
, otherwise the content is cut off when the browser height is less than the content<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom
because this line is decorativetransition
on the element with hover effectpx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@DorianDesings
Submitted
@denielden
Posted
Hello Dorian, You have done a good work! 😁
Some little tips to improve your code:
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom
because this line is decorativemargin
from card
class because with flex they are superfluouspx or %
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
@Sumitkumar01
Submitted
@denielden
Posted
Hi, You have done a good work! 😁
Some little tips to improve your code:
article
tag instead of a simple div
to the container card for improve the Accessibilityalt
attribute of the imagesfigure
container of imagemargin
from .qr-card
class because with grid they are superfluousmin-height: 100vh
to body because Grid aligns child items to the size of the parent containerpx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@Horlaboi
Submitted
@denielden
Posted
Hello Yusuf, You have done a good work! 😁
Some little tips to improve your code:
main
tag and wrap the card for improve the Accessibilityarticle
tag instead of a simple div
to the container card for improve the Accessibilityimg
element must have an alt
attribute, it's very important!alt
attribute of the imagesh3
titlemargin
from .yusuf
classmin-height: 100vh
to body because Flexbox aligns child items to the size of the parent containerpx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
@denielden
Posted
Hi, You have done a good work! 😁
Some little tips to improve your code:
main
tag and wrap the card for improve the Accessibilityarticle
tag instead of a simple div
to the container card for improve the Accessibilitydiv
container of imagemargin
from .content-container
classmin-height: 100vh
to body because Flexbox aligns child items to the size of the parent containerpx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@EasonLin0716
Submitted
@denielden
Posted
Hello Eason, You have done a good work! 😁
Some little tips to improve your code:
main
tag and wrap the main content of the page for improve the Accessibilityarticle
tag instead of a simple div
to the container card of country for improve the Accessibilityalt
attribute of the imagesbody
to change the all theme color of apptransition
on the body to smooth the change theme colorhref
attribute you have to parse it in url
, it can give problems creating links with empty spaces or special characterspx
use relative units of measurement like rem
-> read hereKeep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!