Skip to content
OverviewSolutions
10
Comments
12
devjakov
@devjakov

All comments

  • devjakov•210
    @devjakov

    your font sizes should be larger for the cards, otherwise users would have a hard time reading.

    Also you are missing the active states on the buttons, my cursor does not change when i hover over, this is not a good sign as its missing user feedback.

    The timeframe buttons should be aligned to the left, not middle

    The layout seems fine though, except the profile card is too wide, cheers!

  • devjakov•210
    @devjakov

    if you using css grid try the 'gap' attribute in the grid parent element.

    With gap set at just 2rem you can already seperate all the elements properly

    And for the profile card just set height to 100% so that it matches with the other elements, cheers.

  • devjakov•210
    @devjakov

    hey that looks great!

    Marked as helpful
  • devjakov•210
    @devjakov

    this page starts to break if I increase width above 1080p

    you should make the container have a max-width of some 1000-1200px i don't know exactly but play around

    What i want to say is that at one point all the content of the website should stop seperating and the width should remain fixed, otherwise the boxes have a ton of space between them on 1440p and 4k screens

    Cheers

    Marked as helpful
  • devjakov•210
    @devjakov

    small issues:

    • cancel order button is wrong color
    • 'annual plan' should be bold
    • paragraph should have opacity changed and fixed width

    large issues:

    • this container breaks on all screen sizes, the width should be fixed it shouldnt resize with every screen
    • it doesnt look right on mobile, something is off with your media queries

    hope this helps!

  • devjakov•210
    @devjakov

    Try and change the opacity of your paragraph and the price under Annual plan, it will make it look a lot better and stand out

    Cheers! great solution for your first try

  • devjakov•210
    @devjakov

    hey bro there's a couple of issues with your solution

    • the size of your container is wrong
    • the size of your button is too small
    • the 'order summary' heading wraps when it should be on one line
    • the annual plan and pricing are wrongly aligned

    there's a couple more issues

    Personally I feel like you should just redo the whole thing, it'll help you much more than trying to fix these things

    cheers!

    Marked as helpful
  • devjakov•210
    @devjakov

    this is not responsive unfortunately, the sizing keeps changing and only looks good on mid screens, above 1080p breaks and under 500p it breaks as well

    The width and the height of the container need to be a fixed size

    Marked as helpful
  • devjakov•210
    @devjakov

    im pretty sure you didnt upload it correctly bro, try to commit again through your code editor or through github desktop

  • devjakov•210
    @devjakov

    it works properly when you click preview site, idk why the integrated frontendmentor preview looks weird

    Maybe someone knows? Thanks

  • devjakov•210
    @devjakov

    when the viewport width starts going over 2000px or under 1300px your card sizing starts changing, this is a problem for someone with 1440p screen

    also why have three seperate media queries for one resolution? you can put it all under one

    Cheers bro :D

    Marked as helpful
  • devjakov•210
    @devjakov

    No idea why it shows the mobile design as preview though