Skip to content
OverviewSolutions
14
Comments
9
Maciej
@dreamspice

All comments

  • Maciej•280
    @dreamspice

    Git add, Git commit, Git push

    Only this. And generator new report on this site.

  • Maciej•280
    @dreamspice

    Nice !

    How do u implement functionality: ex. type 'pol' and country starts with 'pol' render without submit form? I need to check your code.

    U can filter countries from A-Z, with filter method:

    state.data.sort(function (x, y) { let a = x.name.toUpperCase(), b = y.name.toUpperCase(); return a === b ? 0 : a > b ? 1 : -1; });

    Also add alt attribute to all flag images, close everything in semantic elements, ex. <header></header>, <main></main>, and add aria-labelledby, aria-label and label for select el.

    Marked as helpful
  • Maciej•280
    @dreamspice

    U can easily change svg color in Figma. Nice work, code looks good :)

  • Maciej•280
    @dreamspice

    Hi, thank you for reply.

    Mmmm...

    U use this div because i can't add white padding for text but i can do it now.

    Ok, then this <h1>We are creative</h1> item should be outside this div?

    <header> <h1>...</h1> </header>

    not

    <header> <div class="header-text> <h1>..</h1> </div> </header>
  • Maciej•280
    @dreamspice

    I will check it later. Thank you.

    Font's for <p>, <a> doesn't work because i forgot to import font-weight: 400, in style guide i found only 600 / 700, 900.

  • Maciej•280
    @dreamspice

    Hi, nice work.

    Desktop version is nice.

    I see some accesibility issues (img alt=""), heading and with semantic tag. Use <nav> tag instead of <div class="nav">.

    For mobile version try set min-height for a few containers.

    All the best :)

    Marked as helpful
  • Maciej•280
    @dreamspice

    Hey !

    Thanks for feedback.

    I think label is for only mhmmm... checkboxes and radio type input.

    I saw something like this:

    <div> <label for="email"> <input type="email" id="email"> </label> </div>

    Use div in that case or not?

    Thanks for that validation.

    All the best.

  • Maciej•280
    @dreamspice

    Hi !

    Thank you for reply and advices :)

    I have updated my code. Thanks for video but something doesn't work i will figure out how to fix it.

    All the best.

  • Maciej•280
    @dreamspice

    Hi, thank you for reply and advices :)

    I forgot to use semantic tags. Yeah, 'main' is probably the best for this case.

    I use 'h2' because i dont' want to change font-size but now i know it's bad practice.

    I will upgrade that and add media queries for 1440px width.

    All the best.