Nanthawat Cola• 80
@balldev1
Submitted
Ibukun Ekunwe
@drvnprgrmr
All comments
- Ibukun Ekunwe• 100
@drvnprgrmr
Posted
Hi there! Congratulations on completing this challenge.
Your solution looks great there's just a couple things I would like to note:
-
You can use the
style-guide.mdfile located in the starter code to help with colors. The one's you're using are not the same ones in the design. -
The color of text of each button is the same as the color of the section it is in.
Tip: You can use the "PerfectPixel" extension to more precisely recreate the designs.
0 -
@satryandi
Submitted
Ibukun Ekunwe• 100@drvnprgrmr
Posted
In the design files, the image and details each shared half of the whole card's width. Your solution doesn't seem to do that.
You can use flexbox on the card and set the flex-basis of the two children to 50% each.
0- iammankatah• 40
@iammankatah
Submitted
This is my completed project i am looking forward to have it reviewed and perhaps better at it next time. you comments and recommendations are all welcome
Ibukun Ekunwe• 100@drvnprgrmr
Posted
You can use flex to center the card vertically by setting the parent's width and height to 100% and 100vh respectively.
As for the accessibility issues, you should always try to use semantic html when coding i.e.
- Use <header> , <main>, <nav> and <footer> tags when possible.
- All your other tags should be contained within the above semantic tags.
- You should use text tags in this order h1 > h2 > h3 ... > p
Marked as helpful
0
