Nida Ismail• 70
@nidaismail
Submitted
looking forward for the feedback
Danielle S.
@dstrickl7
All comments
- Danielle S.• 140
@dstrickl7
Posted
Hi Nida, You may need to check which branch your page is being pulled from on Github. Currently, it's displaying the Github pages default and not your page. Try renaming your html file as index.html and look into removing the docs folder. Your page is currently pulling from that docs folder.
0 - Renata• 10
@RenataEloize
Submitted
Hi! What you think about my code? How I can improve? Please be kind, it's my first time !! hahaha
Danielle S.• 140@dstrickl7
Posted
Hey Renata, Your stylesheet isn't linked to your HTML properly. You're linking to css/styles.css instead of styles.css which is causing your styling to not appear. Once you do that, it'll be easier to give you feedback!
1 - Danielle S.• 140
@dstrickl7
Submitted
I had a lot of issues with the navbar using bootstrap and padding in general. In order to achieve this layout exactly, is it necessary for me to adjust the Bootstrap scss files? I did a little bit, but things started getting messy.
For the mobile navlist, is there a way to make the transition smoother? When it's closed, the navlist jumps back and attaches itself to the navbar. I would like it to just close without attaching.
Danielle S.• 140@dstrickl7
Posted
Thank you so much for your feedback. I am still trying to learn Bootstrap and it's definitely been tougher than just using CSS or SCSS. I will definitely go back and fix some of the bugs and I do plan to keep working on this as I learn more about Bootstrap.
The navbar is indeed Bootstrap. I did my best to use Bootstrap and not default to CSS/SCSS, but I definitely did a couple times when I started getting frustrated with the Bootstrap. I also attempted to edit some of the Bootstrap SCSS files as well but decided not to alter them too much since I didn't fully understand everything.
0 - Tesla_Ambassador• 2,980
@tesla-ambassador
Submitted
Feel free to check out my code (particularly my CSS) and tell me what you think of my style (organization of my code). That feedback will very much be appreciated.
Danielle S.• 140@dstrickl7
Posted
Hi tesla-ambassador! I checked out your CSS code and I think it's logically organized and I think the comments helped with setting up the framework.
Some things I'd like to suggest for the visual aspects of your solution: -If the purple color is pre-defined try using that instead of the default css purple to match the design more closely. -For your images overlay, raise the opacity to around 0.7.
Overall, nice work! Keep coding!
1
