Skip to content
  • Unlock Pro
  • Log in with GitHub
Profile
OverviewSolutions
19
Comments
2
develoba
@eleslin

All comments

  • Edoye•170
    @DoyeDesigns
    Submitted over 2 years ago

    Responsive QR-Barcode page using media query

    2
    develoba•270
    @eleslin
    Posted over 2 years ago

    👋 Hi @DoyeDesign, good job on this challenge!

    If you don't mind, I'll give you some recommendations about your code:

    • You closed your two containers elements (div) after closing the section element, which is the father element.
    • It is recommended to use semantic tags for HTML document. For example, the principal content should be in a main tag and the image could be wrapped in a figure element to give more semantical meaning.

    I hope this will help you! Happy coding! 😊

    Marked as helpful
  • Selvi•30
    @miofri
    Submitted over 2 years ago

    QR code component

    2
    develoba•270
    @eleslin
    Posted over 2 years ago

    Hi Selvi! Nice work!

    I also did this challenge as my first work here.

    Responding to your question, I think it could be solved by applying a height to your body element (for example, 100vh), so that it takes the full screen size, and by setting the .attribution's position to sticky, with a bottom property set to 0.

    Hope this can help you!

    Marked as helpful
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub