
develoba
@eleslinAll comments
- @DoyeDesigns@eleslin
👋 Hi @DoyeDesign, good job on this challenge!
If you don't mind, I'll give you some recommendations about your code:
- You closed your two containers elements (div) after closing the section element, which is the father element.
- It is recommended to use semantic tags for HTML document. For example, the principal content should be in a main tag and the image could be wrapped in a figure element to give more semantical meaning.
I hope this will help you! Happy coding! 😊
Marked as helpful - @miofri@eleslin
Hi Selvi! Nice work!
I also did this challenge as my first work here.
Responding to your question, I think it could be solved by applying a height to your body element (for example, 100vh), so that it takes the full screen size, and by setting the .attribution's position to sticky, with a bottom property set to 0.
Hope this can help you!
Marked as helpful