All comments

• 

  Sol B W• 80

  @solybarr

  Submitted about 4 years ago

  Hello, I used grid for the positioning of the desktop design. The only thing I couldn't do was get the image larger like I saw some other coders did.

  I had an accesibility error so I had to add a "label" element to my form even though it was empty. Its really good to run your html through HTML Codesniffer to get it validated.

  Any tips would be welcome. This is my first solution here and my first time using CSS Grid.

  

  Base apparel with Grid positioning for desktop

  4

  1

  0

  

  Eliazar Lopez• 25

  @eliazarnd

  Posted about 4 years ago

  Hello, i like how you used grid for creating a layaout

  I saw your structure and code of css, i found out your issue, your image can not get full size, because you need to give a height to your container because thats the main feature of landing page.

  Your image needs a property like background-size: cover, with this property you cover all the container of your image.

  Thats it,

  Gretting and continue relearning all wonderful things of this world.

  1