Moeen Mahmud• 180
@moeen-mahmud
Submitted
ellienndea
@ellienndea
All comments
- ellienndea• 130
@ellienndea
Posted
Hi Moeen, this looks really good despite some minor issues, I'd say, and the html and css is clearly written as far I can judge it being a newbie myself. ;) I did that challenge not long ago and got helpful feedback, which I want to pass on to you (some of it). :)
- The buttons in "normal" state should have a transparent border, so they dont move, when you hover on them.
- Giving the cards a max-width would prevent, that they stretch out too much.
Happy coding! 😊
Marked as helpful
2 - jing• 20
@jing0429
Submitted
Is there any part that I can do better? Thank you All !!!
ellienndea• 130@ellienndea
Posted
Hi Jing, this looks pretty good. 😊 One tip that I got, is to not use px but em and rem instead. On my screen the card is not properly centered, instead of using position: absolute; top:...; left:... you could make the body a flex-container width height: 100vh(viewport height) and use justify-content: center and align-items: center. The mask is a little too light. For your first project it looks pretty good! 😊 Happy coding!
1 - Moh• 230
@Moh2106
Submitted
hi everyone if he has things to improve all comments are welcome thank you.
ellienndea• 130@ellienndea
Posted
This looks good so far. 😊 For a better horizontal centering and a vertical centering, you could make the body a flex-container with a min-height of 100vh(viewport height) and justify-content: center and align-items: center. Happy coding! 😀
1 - Agata Liberska• 4,015
@AgataLiberska
Submitted
Please try it out and if there's any errors please let me know so I can fix them. Copied most of the behaviour (when it comes to input, display and navigation) from Windows system calculator. I tried to make it accessible so keyboard navigation can be used (numbers + operators or use arrows to navigate keypad). Color themes can be switched with keyboard too. However! I found out that NVDA screen reader hijacks arrow keys however so things don't work as they planned, and overriding that seems counter productive. I also checked with Thunder and while the navigation works fine, it doesn't read out much - but I've only just installed it so haven't had much time to get used to how it operates. Lots more to learn I guess :)
ellienndea• 130@ellienndea
Posted
Hi Agata, this calculator app is really great. On my laptop it works perfectly fine with mouse and keyboard. :) I really like your focus on accessibility, it's so important! Happy coding 😊 Linda
0 - Calvin.A.S• 120
@calvin17
Submitted
Hi!!! ✨🎉, I have completed this challenge, I would appreciate any comment about my solution.
Thanks.😊😊
ellienndea• 130@ellienndea
Posted
Hey Calvin, that is well done. It looks preety much like the original and in your index.html I really like the class names you chose! 😊 Cheers, Linda
0
