Emad Jaber
@emad2411All comments
- @cholis04@emad2411
Great solution
as I can see you have two accessibility issues.
- your footer should be contained in a <footer> tag
- your main content should be contained in a <main> tag
other than that I can see everything is perfect , great coding.
- @jearrington@emad2411
hi Jason,
good work , there are few comment which will improve your code:
- as you can see you have an Accessibility issues like you are using h5 instead of h1 since heading can be increased by one only .
- wrap your html code with main and footer.
- you can use css variables for colors : :root { --pale-blue: hsl(225, 100%, 94%); --bright-blue: hsl(245, 75%, 52%); --very-pale-blue: hsl(225, 100%, 98%); --desaturated-blue: hsl(224, 23%, 55%); --dark-blue: hsl(223, 47%, 23%); }
- pay attention to your margins for the cancel order link
- add transitions to your interactive links so when you hove on them you have a smooth transition between colors.
I hope my comments are useful
Marked as helpful - @alexandre-dev29@emad2411
hello Alexandre,
good work here are some comments:
- change the background-color of the .card_plan to --very-pale-blue
- decrease the top and bottom padding in the .card_plan to match the original design
- i think also you need to increase the btn margin-top.
- you didn't put a hover effect on change link and cancel order link.
I hop above comment helps to improve your layout
- @marcelo-jrs@emad2411
Hi Marcelo,
I learned how to do the background by reading about the CSS background-position Property. its really useful in such cases .
Please view the given report in your solution page since it seems you have some issues in the ACCESSIBILITY and your HTML
Marked as helpful