Skip to content
OverviewSolutions
7
Comments
9

Eman Salama

@emy-dev56120 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • oduwa-A•160
    @oduwa-A
    What are you most proud of, and what would you do differently next time?

    Focusing on the HTML for the first time made the process extremely easy to tackle, to where the mobile is flawless and I barely had to make edits to make the desktop version work. I still had issues, of course, and it isn't perfect, but I am definitely proud of how streamlined the process was. I will definitely do this again the future.

    What challenges did you encounter, and how did you overcome them?

    Messing around with the prices to make them spaced properly in both versions was difficult, but messing around with rem size for the overall width made it alright and responsive in all different sizes I believe.

    What specific areas of your project would you like help with?

    I need help with the Desktop version of the image, cause it squishes at the top and bottom and I didn't know how to fix that.

    Product Review using picture element + flexbox

    1
    Eman Salama•120
    @emy-dev56

    Congratulations on completing this Challenge!

    I like how you used the picture tag to show different images based on media size :) I think you can center the box vertically by making the body display flex and set justify-content: center; align-items: center; min-height: 100vh;

    I'm looking forward to seeing more of your work. Keep up the good work :)

  • Eman Salama•120
    @emy-dev56

    Congratulations José for completing this challenge. you have created a super design; your design looks very much like the screenshot. As the next step, I suggest 1- Use semantic HTML tags like main, footer, section, etc for better accessibility so I think it would be good to wrap the card in main and add a footer for "Challenge by Frontend Mentor." 2- It's always a good practice to start your CSS with reset CSS so the layout looks the same on all browsers. You can try Josh Comeau's approach to resetting the CSS.

    I'm looking forward to seeing more of your work. Keep up the good work :)

  • Eman Salama•120
    @emy-dev56

    Congratulations Bailey for completing this challenge. you have created a super design; your design looks very much like the screenshot. As the next step, I suggest 1- Use semantic HTML tags like main, footer, section, etc for better accessibility so I think it would be good to wrap the card in main and add a footer for "Challenge by Frontend Mentor." 2- It's always a good practice to start your CSS with reset CSS so the layout looks the same on all browsers. You can try Josh Comeau approach for CSS reset.

    I'm looking forward to seeing more of your work. Keep up the good work :)

    Marked as helpful
  • Gustavo Gutiérrez•390
    @gustavo2023
    What are you most proud of, and what would you do differently next time?

    I think I did a good job structuring the HTML, however I have some doubts about using and h1 tag for the main text in the component. Maybe I could have used a different tag that fits better for that purpose.

    What challenges did you encounter, and how did you overcome them?

    The only thing that felt kind of challenging was aligning the text in the place I wanted, aside from that the rest wasn't difficult.

    What specific areas of your project would you like help with?

    I would like to receive any feedback on things I may have done wrong or things I could have done in a more efficient way. In regards to the way I positioned the elements I would like to know if there better practices that I should have implemented, or things I should change or correct. Any feedback on the use of the tags in my html would be appreciated. As for the CSS properties I used and their values I would also appreciate any feedback on improvements I can make.

    QR component using HTML and CSS

    #accessibility
    1
    Eman Salama•120
    @emy-dev56

    Congratulations Gustavo for completing this challenge. you have created a super design and your code is super clean. As the next step, I suggest moving the "Challenge by" text to the footer instead of having it in the main section. also, it's a good practice to start your CSS for any project with reset CSS so your CSS doesn't look different on different browsers.

    I'm looking forward to seeing more of your work. Keep up the good work :)

    Marked as helpful
  • Rgeb1•130
    @Rgeb1
    What are you most proud of, and what would you do differently next time?

    I'm really pleased with how the project turned out; it’s a lovely design, and I'm glad I was able to do it justice. Moving forward (based on feedback I received), I’m considering using rem instead of px for setting widths. I believe rem is a better choice because it scales more consistently across different screen sizes and respects the user's accessibility settings.

    Also, I learned how to directly target ol/ul > li bullet points or numbers to style them independently, instead of styling the entire li element. This can be done using the li::marker pseudo-element.

    Responsive Recipe Page using HTML and CSS

    1
    Eman Salama•120
    @emy-dev56

    Perfect

  • Jennifer Chen•50
    @JenniferjjChen
    What are you most proud of, and what would you do differently next time?

    Not particularly proud of anything in the challenge.

    What challenges did you encounter, and how did you overcome them?

    I initially wanted to use grid to display the profile, but changed to flex because I wasn't sure how to center the texts with grid. Same with the social links. I just decided to use the break tag.

    What specific areas of your project would you like help with?

    Is there a better way to format the tags instead of using the break tag? I know some tags automatically start on the next line, but when trying to use semantic html, I'm not too sure.

    Responsive css design using flex.

    1
    Eman Salama•120
    @emy-dev56

    Perfect

View more comments