Myles Enriquez

Latest comments

• 

  Allison•40

  @agottlieb

  Submitted over 4 years ago

  

  Article Preview using HTML, CSS and JS, mobile-first

  1

  10
  

  Myles Enriquez•30

  @enriquezm

  Posted over 4 years ago

  Hey agottlieb,

  Regarding changing the share button background color. You're already selecting the button with your .btn query. Now all you need to do is toggle an active class on it when you actually click it. This class would then be the background styles you want.

  Good job!

  0
• 

  Gerardo Castañeda•80

  @osocash

  Submitted over 4 years ago

  

  html ,css, cards

  2

  10
  

  Myles Enriquez•30

  @enriquezm

  Posted over 4 years ago

  Hey osochash great job on the conversion!

  Here's my feedback:

  • For the container .cards, I recommend you use display: grid. You'll be able to define your grid gaps and position cards easier where ever they need to be place on different breakpoints.
  • I noticed inside a card you have a div that contains the image. You can get away from that by just defining your styles on the img itself. I recommend doing this so we're not introducing nodes to the DOM that aren't needed.
  • For a card. I recommend using display: flex; flex-direction: column; Essentially, there are only 3 items in a card. Two are aligned to the left, the third (the image) is aligned to the right (using align-self: end).

  2