Skip to content
OverviewSolutions
2
Comments
3

Anthony Oyathelemhi

@frontendtonyLagos, Nigeria75 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

Latest comments

  • Anthony Oyathelemhi•75
    @frontendtony

    Fine work Jeremy!

    A few things that could be better:

    • The wavy background images don't cover the entire width on large displays. You can fix this by adding background-size: contain right after the background-image declaration.
    • The "hero-text" is not supposed to grow beyond a certain point. You should add max-width: 60ch to the style to correct this. See here for how ch works
    • "screen mock ups" image should have a width and height. Use the values you can see on Figma. See here to understand why this is a good practice
    Marked as helpful
  • Anthony Oyathelemhi•75
    @frontendtony

    Design implementation in on point 👌🏽

    Looking at your markup however, I noticed a pattern that you could work on improving.

    1. Use semantic HTML markup. For example 'Why choose Easybank?' should be a h2 tag, not a div.
    2. Use less markup. There are lots of unnecessary nested div tags where just one could've worked. In each sections, you used 3 'wrapper' tags, you could've applied styles on just one to achieve the same thing
    3. Use the alt attributes in your img tags to describe the image to visually-impaired users
    Marked as helpful
  • Anthony Oyathelemhi•75
    @frontendtony

    The colors look a bit different from the design, including the button background and text colors. Other than that, it looks pretty close to the design visually. Good job