Skip to content
OverviewSolutions
8
Comments
11
Dimitrios Politis
@grmajik

All comments

  • Dimitrios Politis•285
    @grmajik

    Well you forgot that small background image on the top left corner but good job, keep it up ! 💪

    Marked as helpful
  • Dimitrios Politis•285
    @grmajik

    It looks great on my end. Good job. Keep it up 💪

  • Dimitrios Politis•285
    @grmajik

    What can be done is to remove the sign in with google thingie.

    I can't see the solution because I don't trust whatever this sign-in thing is actually doing.

  • Dimitrios Politis•285
    @grmajik

    DEL and RESET button do the same thing. DEL is to delete only one digit from the input. Also it feels kinda weird to have to click exactly on the thumb to switch a theme.

    Marked as helpful
  • Dimitrios Politis•285
    @grmajik

    Why do I have to click either 1 2 or 3 to switch theme? I'd like to click on the thumb to switch themes.

    Marked as helpful
  • Dimitrios Politis•285
    @grmajik

    If I were you, I'd start over. However, if you want to debug this, imagine this.

    Imagine that you have a box (a regular DIV), then in that box you have two more boxes.

    One box holds your image (do max-width: 100%; height: auto;) Another box holds all your text (in here, format the text however you want)

    Now, do display: flex; on the BIG BOX (the outer div). Your two inner boxes will be displayed side by side.

    Now if you do display: flex; height: 100vh align-items: center; justify-content: center; on the BODY tag, you'll get everything in the center of the page. Go from there and figure out the rest.

    Happy coding 💪

    BTW: Get rid of Bootstrap

    Marked as helpful
  • Dimitrios Politis•285
    @grmajik

    Another comment I posted on a different solution

    Remember that GitHub pages are scoped with repo names.

    You are including your CSS with

    "link rel="stylesheet" href="/css/styles.css"

    This resolves to https://elisabethp028.github.io/css/styles.css

    but you want https://elisabethp028.github.io/Stats-Preview-Card/css/styles.css

    Simply change link tag to

    link rel="stylesheet" href="/Stats-Preview-Card/css/styles.css"

    p.s add the < > in link tag above.

    Marked as helpful
  • Dimitrios Politis•285
    @grmajik

    This is cool. Way to go 💪

  • Dimitrios Politis•285
    @grmajik

    Hi there.

    1. Your header seems too big in comparison to the design.

    2. Your transition for the footer links feels too slow and I can't distinguish between each category for the links. Make the "product" "contact" "connect" text a different styling. Maybe make the other links smaller ?

    3. On mobile devices you can't ever "hover" on elements, so I doubt your mobile nav menu would work for these devices. Maybe you'd want to make both desktop version and mobile work on click to expand the dropdown.

    Overall good job, keep on coding brother ! 💪

  • Dimitrios Politis•285
    @grmajik

    Nice one. Few things I noticed.

    1. Subtraction does not work properly. It does addition instead.
    2. If you click on a number then press DEL, the number field is halved in size!

    Good job. 💪

  • Dimitrios Politis•285
    @grmajik

    Why would you ever have all questions opened? Figure out how to close an opened question when you open another, problem solved.

    P.S: Your 1440px version looks a bit too big, almost double the original design, other than that, good job 💪