Dre
@hadreemustaffaAll comments
- @Posedion1920@hadreemustaffa
Hi @SeenDGK.
For the QR image, you are missing a dot before the " / " in the image src.
Like so: <img src="./image-qr-code250x250.png" alt="">
For <link rel="shortcut icon" href="./images/favicon-32x32.png" type="image/x-icon">.
This image does not exist in your repo. If you choose to include it in, you can either:
- create a folder called "images" where your HTML is, and add the icon there.
- or put the icon where the HTML is, and change to href="./favicon-32x32.png"
I hope this is helpful.
- @yosephwinata@hadreemustaffa
Hi @yosephwinata.
You said you got different results. Is it the font colors and line heights? These are the only two things I noticed that's different from the design.
In the style.guide.md file, it is stated that, for font colors:
- "Verified Graduate" has the same color as the person's name with 50% opacity
- Review paragraphs inside the quotations have the same color as well, but are at 70% opacity
You can achieve these by using
hsla()
function in CSS.For example, if the person's name color is
hsl(217, 19%, 35%)
,- then, Verified Graduate is
hsla(217, 19%, 35%, 0.5)
- and the paragraph for that card is
hsla(217, 19%, 35%, 0.7)
.
The last number in
hsla()
function sets the opacity value (0.0 - 1.0) for the color.For line-height, maybe set
line-height: 1.25
to <h1>.That's all I guess. Please correct me if I'm wrong.
Marked as helpful