Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @ramos-codes

    Submitted

    Issues that I have not resolved:

    • The responsiveness of the site suffers as soon it get close to that media query at around 650-750px width => I still need to practice and learn more about relative width/heights
    • I have yet to implement the required email error message
    • Compared to the original some elements might be bigger or smaller

    If you could suggest any approaches or links to resources to resolve the current issues, that would be greatly appreciated

    A link to the live copy

    Hannah 655

    @hannah-saurusrex

    Posted

    Looks great Adrian! I think your comments above are spot on. I'd add some margin to the ping logo up top. Looks like based on the design files, your solution could just use a bit more spacing overall. Keep up the great work!

    1
  • Hannah 655

    @hannah-saurusrex

    Posted

    looks like I just misspelled the word 'click'. now that that's been fixed, this should be working correctly.

    0
  • @shahmirfaisal

    Submitted

    After a long time I finally use vanilla javascript in my project. It was a fun project. Any feedback will be appreciated :)

    Hannah 655

    @hannah-saurusrex

    Posted

    Great job using vanilla JS! 🎉

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    Awesome work on this! 🎉✌️

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    Great work on this! I wonder if the white bar at the top, where the categories chosen show up, could be hidden when no category is picked. It looks a bit odd to have it there when there are no categories chosen. Looks awesome though! 🎉✌️

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    Great work! 🎉 It looks like you could add a bit of margin between the header area, and the dashboard tiles. But this solution looks great across different devices. Awesome job! 🙌🏻

    2
  • Hannah 655

    @hannah-saurusrex

    Posted

    Excellent work on this! 🎉 I love how smooth the transition is both on the toggle button and on the page elements. 🙌🏻

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    nice work, this looks great! ✌️

    1
  • Hannah 655

    @hannah-saurusrex

    Posted

    nice work!

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    Great work on this challenge! ✌️

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    This looks awesome! I noticed sometimes the border countries don't want to populate when switching from dark to light mode. 🤔 But you did an awesome job, nice work!

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    awesome work! I'm tackling this one now. ✌️

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    This looks awesome, great work!! On mobile, it looks like the second image is expanding outside of it's container, causing the page to want to scroll right. You could try adding a fixed width to the image at your break point :)

    1
  • Hannah 655

    @hannah-saurusrex

    Posted

    Hi there, I just played your rock/paper/scissors game, but it doesn't seem like the shuffle is working. I always get the same "computer picked" result for each option I choose. Here is a great article talking through how to shuffle items in an array :) https://gomakethings.com/how-to-shuffle-an-array-with-vanilla-js/

    1
  • Hannah 655

    @hannah-saurusrex

    Posted

    Just as an FYI, I following along w/ Florin in his video here: https://www.youtube.com/watch?v=PcSUEo0P0GU&list=PLgBH1CvjOA63Xvt0BaeQ7zL4KXX96Wbgp I made some of my own tweaks, such as adding classes to all element tags and variables for the hsl colors.

    0
  • Hannah 655

    @hannah-saurusrex

    Posted

    Awesome job! The transitions are super smooth. I love the way the 'computer picked' tiles come onto the page, and the two sections slowly move apart as the 'play again' button comes on.

    1
  • Hannah 655

    @hannah-saurusrex

    Posted

    Wow, this is incredible!! Great work!

    1