eadq001• 70
@eadq001
Submitted
P
Heba Ahmad Saleh
@hebaahmedsaleh
All comments
- PHeba Ahmad Saleh• 170
@hebaahmedsaleh
Posted
Great job , we need more accessible markup like in buttons you made them as divs so you can put role="button". you better have readme file contains specs of the task on github not only the deployed link.
Marked as helpful
1 What are you most proud of, and what would you do differently next time?
- What I would do differently is get into a habit of introducing more breakpoints for different screen widths.
What challenges did you encounter, and how did you overcome them?
- Resizing image within div elements still not intuitive to me but got used to it faster after finishing the previous challenges.
What specific areas of your project would you like help with?
- Nothing I could think of right now
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
Great job, may be better to have the readme file attached in the repo. you can use css variables in colors and the margin top of the main card may be better be 15% and also using accessible html markup like <main> for the main div and sections.
0- Nyerho Avbenagha• 30
@Nyerhowho9
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud that I finished the project quickly.
What challenges did you encounter, and how did you overcome them?
Not much challenges
What specific areas of your project would you like help with?
I would like to know if my code is semantic and well arrranged.
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
Great job , I have bo comments but may be you can use css variables for color.
Marked as helpful
0 - Rawle Springer• 10
@RawleSpringer
Submitted
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
from the overview on the site itself and the generated screenshot, I think you need to regenerate it as it works good in the link but the generated screenshot is cropped. in buttons you may better make it on hover ---> cursor: pointer to give the feeling of the action you will take.
0 - joacomenda• 150
@joacomenda
Submitted
What are you most proud of, and what would you do differently next time?
I'm most proud of how the grid layout turned out.
What challenges did you encounter, and how did you overcome them?
Finding a way to recreate the desktop layout was very difficult
What specific areas of your project would you like help with?
Nothing at the moment.
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
Great job but I think if the all content become higher, it may be so similar. may be it just a margin or padding needed to be changed.
1 - PPhilippeItsMe• 100
@PhilippeItsMe
Submitted
What are you most proud of, and what would you do differently next time?
Nice challenge.
I put the " on Daniel cards with a background approch.
I wanted to do it with the flot technology but I didn't succeed.
Need to dig on this one.
What challenges did you encounter, and how did you overcome them?
Same
What specific areas of your project would you like help with?
Same
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
the grid partitioning is so easy, great job.
0 - Demaxs26• 80
@Demaxs26
Submitted
What are you most proud of, and what would you do differently next time?
Hello,
Here is my solution to the challenge "four card feature section master" I found it much simpler than the last one
I d'ont Have any question
Have a great day
What challenges did you encounter, and how did you overcome them?
/
What specific areas of your project would you like help with?
/
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
Great job, but I noticed your css classes are named like card 1 card 2 etc, I feel like if one work on the same project with you will need to see more expressive names for example team-builder__card and so on. the repo shall contain the readme, inorder to be readable what is expected and it is the same readme file with the task itself. may be also ou can use in css the css colors variable which in style guid file.
Marked as helpful
1 - PDeepti Singh• 120
@DeeptiGit22
Submitted
What are you most proud of, and what would you do differently next time?
The final result looks pretty much the same as the provided one.
What challenges did you encounter, and how did you overcome them?
To change the image as per the screen size. Needed to google it a little bit.
What specific areas of your project would you like help with?
.
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
Great job, I like the naming dor css colors. I think you need to make the content card sections are equal as each 50% of full width and the font sizes are bigger.
Marked as helpful
0 - Cheosphere• 1,040
@Cheosphere
Submitted
...made with a lot of love 🤘🏻🙂
PHeba Ahmad Saleh• 170@hebaahmedsaleh
Posted
it is pixel perfect, amaaazing but I have a question you are working with px for example the links has fixed height 45px ? but in real life work designers always request getting dynamic heights according to internal paddings and font-size. I think if we know the screen size of the implemented. it can be calculated not to be static height, what do you think ?
1
