Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Mitchell Gould• 250

    @helphop

    Submitted

    I tried to make the code as clear as possible. I also went through many iterations and refactoring to use components to reduce the amount of code I wrote.

    If you know of some tricks or better ways of coding things I would be very appreciative of your feedback.

    Mitchell Gould• 250

    @helphop

    Posted

    Update I have just tested the site using the lambdatest.com platform. This enabled me to test it on Windows10 Chrome, Firefox, Edge . On all of these the mobile menu is working as is the map.

    I have hovered over the photos on the about us 'Leaders' sections and I don't get the flickering on these browsers.

    Let me know if I have fixed these issues and if not if you could let me know the OS and browser and version that would help me out a lot.

    Thanks.

    1
  • Mitchell Gould• 250

    @helphop

    Submitted

    I tried to make the code as clear as possible. I also went through many iterations and refactoring to use components to reduce the amount of code I wrote.

    If you know of some tricks or better ways of coding things I would be very appreciative of your feedback.

    Mitchell Gould• 250

    @helphop

    Posted

    Ok I just updated the deploy that now includes the map. I tested it no Mac Chrome, Safari and Firefox and it's working.

    Now for the navigation I don't understand why that is not working. I'm no a Mac but I should think it would work in windows. Its vanilla JS so not sure what to do to fix this. Any suggestions appreciated.

    Please note that when I updated the code and pushed to the repo the server redeployed to a different url. I updated that url so to see the update make sure you click the 'Preview Site' button at the top of this page.

    0
  • Mitchell Gould• 250

    @helphop

    Submitted

    I tried to make the code as clear as possible. I also went through many iterations and refactoring to use components to reduce the amount of code I wrote.

    If you know of some tricks or better ways of coding things I would be very appreciative of your feedback.

    Mitchell Gould• 250

    @helphop

    Posted

    Thanks everyone for the feedback. I will have a look at the issued you have indicated and see how I can fix them. It's a bit difficult as on my side using all of the browsers it all works.

    Update I think I know the issue. When I deployed I forgot to move the leaflet folder over. I will update the site soon.

    Thanks for pointing it out.

    0
  • Mitchell Gould• 250

    @helphop

    Submitted

    I had some challenge placing the circles. I think I've worked it out the way I have done it but if anyone has other suggestions I would welcome them.

    Mitchell Gould• 250

    @helphop

    Posted

    Excellent. I will do as you suggest. Thanks again.

    1
  • Mitchell Gould• 250

    @helphop

    Submitted

    I had some challenge placing the circles. I think I've worked it out the way I have done it but if anyone has other suggestions I would welcome them.

    Mitchell Gould• 250

    @helphop

    Posted

    Hey Matt,

    Thank you very much for your awesome feedback. I really appreciate you taking the time to have a look at the site and reflect on some ways I can improve. I agree I have to bite the bullet and do some client side validations using JS. I have been focusing more on improving my css skills so I kinda punted that the JS work.

    I have a question about feedback. I have not received much feedback from the community about my work so far. This is in fact the first time I am receiving feedback and I really appreciate it. What I would like even more and would be willing to pay for is to go over my work with someone on your team to discuss other ways to improve my code so that I can really push the usefulness of these exercises and get the most out of them.

    Does FrontendMentor provide any services like this?

    Best, Mitch

    0