@Oluwajuwonomoyele
Submitted
Looking to hire developers?
@iadefidipe
@Oluwajuwonomoyele
Submitted
@iadefidipe
Posted
Hi @Oluwajuwonomoyele,
Great implementation you have here. Just a few improvement I can point out.
@RodCri
Submitted
@iadefidipe
Posted
Great work @RodCri! but you have a lot of improvements, I think you could make:
@akalizk113
Submitted
@iadefidipe
Posted
Great work @akalizk113! Just two improvements, I think you could make:
Marked as helpful
@GhostemaneUrs
Submitted
@iadefidipe
Posted
hi @GhostmaneUrs, your implementation is great. The page overflows on smaller views, you might want to check that, by probably giving the page a max-width. Not really important, but the buttons styles should also have transition time
@MartinLundqvist
Submitted
@iadefidipe
Posted
hi @MartinLundqvist great implementation. Your project only seems to have spacing issues, i feel you can do better with the spacing in the desktop view. The cards are not centered in the mobile view and the header also has some padding issues
Marked as helpful
@thekindbard
Submitted
izi pizi
@iadefidipe
Posted
Great Implementation! I think you need to fix the mobile view left and right padding, so the elements dont just span across the page as it is now.
Marked as helpful
@aaron-romanick
Submitted
How to Play
localStorage
so they will persist on the next visit to the pageCSS
will-change
property, but I've also read this can put on a strain on resources. I didn't notice a drop in performance either with or without it, so maybe it would be better to go without?top
property and animating it. I know animating the top
property requires a re-paint of the page and thus is not high-performance. If anyone can think of a way to get the rules dialog exactly centered on the page without using it, please let me know.calc
function?HTML
@iadefidipe
Posted
This is great, I love the animations. I am definitely studying your implementation.
@peirstom
Submitted
This was my first challenge on Frontend Mentor. It took me a full day to develop this. My major obstacle was to create responsive design. I took this challenge to confront myself with where I am standing currently with my design skills. I learned that I have a lot to learn to become more effective at writing SCSS. I am still have problems understanding the Flexbox properties, media queries and mixins.
@iadefidipe
Posted
Great job Tom, you might want to work on your font sizes on smaller screens, other than that, you did a very nice job. Also check out the issues flagged by the platform. Keep Learning! cheers
Marked as helpful
@dewslyse
Submitted
Comments and feedback welcomed. Thanks.
@iadefidipe
Posted
Great job, your implementation is almost pixel perfect. The platform flagged some accessibility issues, you should check that out. cheers
@zokn
Submitted
It is not that complex, it comes in handy to reinforce css
@iadefidipe
Posted
Great job.
Instead of using ID which should be unique for each element. Use classes, it makes your styling more easy to, and you can use a class for more than one element too
the whole card is not well centered on all screens.
you should have main container, so you can center the body element. You can also put the text and image section in the container and flex them. See if that helps.
@krishna-nayak
Submitted
I tried my best. Give your opinion or cool idea by which i can improve this page.
@iadefidipe
Posted
Looks, great on all screens. But since you have got a style sheet, you dont need the inline styles
@YannikS14
Submitted
I am wondering if there is a better way to position the bubbles in the background. Currently it's positioned like in the design examples, but just for widths 1440px and 375px. If the width changes, the bubbles move unintended or out of the visible area.
@iadefidipe
Posted
You can create media queries for more screen widths and style/position the background for them. Start the mobile background image from the 768px screen width and position it for that width, keep the mobile screen size position. you can position the desktop background Size for 1024px screen width too.
Your implementation is great, keep coding!