@Khoded1
Alessandra Oliveira
@itsale-oAll comments
- @itsale-o
Congratulations on completing the challenge!
About your issue: you can put a
<div>between the first and the second sections. Something like this:<div id="section1"> your code here </div> <div id="bg-div"></div> <div id="section2> your code here </div>and then, on your CSS file you ajust the
bg-divby putting thebackground-imageand giving thedivaheightthat fits the whole background image.Marked as helpful - @Sanjoclinton@itsale-o
Congratulations on completing the challenge! Nice work.
About your issues: if you put the qr code image inside a div is easier to centralize
You could do something like this:
- On the HTML
<div class=qr-code> <img src="qr-code"> </div>- On the CSS
.qr-code{ display: flex; align-items: center; justify-content: center; }If you want, you can even put the texts on another div, and centralize it as well. It's easier to work with single divs, one at a time (talking from my personal experience)
Marked as helpful - @SeanBailey15@itsale-o
Congratulations on completing this challenge!
I'm not a master coder myself, but for me your code is pretty clean, and the solution looks very nice.
The minimum change I'd make is to put the font-family on the body, then you don't need to say what's the font everytime, since it doesn't change. Of course is not necessary, it's just something I prefer to do
Marked as helpful - @faruquedewan@itsale-o
About the first question: I use one CSS file for both. I did
- @media(max-width: 1400px) {here I did the desktop deseign} and then
- @media(max-width: 700px){here I did the mobile design}
This usually works.
About the icons: if I get the question right, if you use align-items: center, it may solve the problem
