Skip to content
  • Unlock Pro
  • Log in with GitHub
Profile
OverviewSolutions
1
Comments
1

Jonas Fiedler

@jefiedlerCologne; Germany30 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

  • Response QR code component challenge using vanilla CSS and HTML


    Jonas Fiedler•30
    Submitted about 1 year ago

    I would like to understand why I have to set the height and width of the body to 100%, whereas I have already set the HTML to 100vh and 100vw.

    It may seem a bit ridiculous, but CSS has never been my strong point, it's more of a try and hope it looks good.


    1 comment

Latest comments

  • Danae Lescano•270
    @Lescano713
    Submitted about 1 year ago

    QR code Component using flexbox and css custom properties

    2
    Jonas Fiedler•30
    @jefiedler
    Posted about 1 year ago

    The solution is good. The design was kept as intended. It is normal that a design cannot usually be reproduced 1 to 1 on the web. Which is why there is a discrepancy. This is not a big deal.

    Feedback on the CSS:

    The only thing I notice is that your CSS is very difficult to read. This applies especially to the section from body, .box-container { } . Personally, I would separate the classes more. It's nice that you use CSS features here, but unfortunately this makes it a bit unreadable. In addition, you can only use this CSS for this project and only for this area. If you split up the CSS more, e.g. into the classes .card, .card-content, .card-media, you can also use them elsewhere. In addition, this increases readability.

    Feedback on the HTML:

    The HTML is generally good. It might make sense to use main for the div with the class box-container and the tag footer for the div with the class attribution instead of the divs. This is semantically more correct HTML. If this were a React component, I would also use divs.

    Otherwise, all other tags fit, I would possibly replace the h3 tag with an h1 tag and possibly adjust the font size. But this is not absolutely necessary.

    Otherwise, a really great job. Keep up the good work.

    Marked as helpful

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub