Latest solutions
Response QR code component challenge using vanilla CSS and HTML
Submitted about 1 year agoI would like to understand why I have to set the height and width of the body to 100%, whereas I have already set the HTML to 100vh and 100vw.
It may seem a bit ridiculous, but CSS has never been my strong point, it's more of a try and hope it looks good.
Latest comments
- @Lescano713@jefiedler
The solution is good. The design was kept as intended. It is normal that a design cannot usually be reproduced 1 to 1 on the web. Which is why there is a discrepancy. This is not a big deal.
Feedback on the CSS:
The only thing I notice is that your CSS is very difficult to read. This applies especially to the section from body, .box-container { } . Personally, I would separate the classes more. It's nice that you use CSS features here, but unfortunately this makes it a bit unreadable. In addition, you can only use this CSS for this project and only for this area. If you split up the CSS more, e.g. into the classes
.card
,.card-content
,.card-media
, you can also use them elsewhere. In addition, this increases readability.Feedback on the HTML:
The HTML is generally good. It might make sense to use
main
for thediv
with the classbox-container
and the tagfooter
for thediv
with the classattribution
instead of thediv
s. This is semantically more correct HTML. If this were a React component, I would also usediv
s.Otherwise, all other tags fit, I would possibly replace the
h3
tag with anh1
tag and possibly adjust the font size. But this is not absolutely necessary.Otherwise, a really great job. Keep up the good work.
Marked as helpful