mmmelomano• 10
@mmmelomano
Submitted
Jishan
@jish0101
All comments
- Jishan• 290
@jish0101
Posted
Change the background colour and cards sizes, a bit bigger rest is good
0 - Nayana• 30
@nk7608
Submitted
Jishan• 290@jish0101
Posted
There's no carousel, the sizing of most elements are either bigger or smaller. Also you can add some padding to the sides in the sections before Cta (orange section) and make everything centred. You can see my code for proper sizes if you want to
Marked as helpful
0 - Soi Thangsing• 50
@soithangsing
Submitted
Jishan• 290@jish0101
Posted
Right image is bigger, it should be a bit smaller, wrapping the heading, content and image and altering sizes can make it closer to the design
0 - Milosz Lewandowski• 130
@yerbaMatte
Submitted
Hi, what do you think?
Jishan• 290@jish0101
Posted
Image isn't showing up.? And the card is a little taller.
0 - Elaine• 11,420
@elaineleung
Submitted
I've been wanting to build a slider because one of the recent tutorials from Kevin Powell features an FEM page with a slider. The most challenging part wasn't building the actual slider but positioning all the SVGs and to make sure they can be viewed optimally while still maintaining a good distance/relation with the surrounding elements. It's also interesting that one of the requirements is to use arrow keys for the slider because I've read that for a screen reader user, it's best to have users use the tab key for navigation and not so much the arrow keys. I did come across some insightful articles on the challenges of building an accessible slider/carousel, and I do hope to work on this some more later. I also hope to put in some opacity transition later on, but I think on the whole, everything works for now, and I think this was a good attempt in building a slider that can be accessible.
Do let me know if something isn't working as it should. Happy testing!
Jishan• 290@jish0101
Posted
Nice 🐱🏵️
1 - Tom Golding• 250
@ComanderPotato
Submitted
Please be as critical as possible, all criticism is good criticism. Still new to this I had trouble trying to learn it up (this is my first frontend mentor challenge), had to hard code widths because it wasn't working properly, I need to work on the amount of code I have written down, I tried to follow the DRY rule I think. I tried to stay on top of semantic HTML, it was difficult trying to center the container so its a bit of funky code, flex => justify and align center wasn't working for me only align was, and I tried to keep it accessible but wasn't sure what else to add. Im familiar with js but I wanted to keep it just HTML and CSS so I've set the images to display none depending on screen size, and as I'm typing this i see i put too much padding/margin on the pricing for mobile but oh well. I appreciate the feedback from anyone.
Jishan• 290@jish0101
Posted
It looks good, do margin bottom properly and put that title after the box, check mine.
Marked as helpful
1
